diff --git a/TASKS.md b/TASKS.md index baa1bac..ec3e8de 100644 --- a/TASKS.md +++ b/TASKS.md @@ -44,7 +44,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co ## 10. Settings window - [x] T16 Settings window: categories, General rows, live apply and save. -- [ ] T17 Appearance: theme grids with previews, font, cursor with preview, opacity, blur, padding. +- [x] T17 Appearance: theme grids with previews, font, cursor with preview, opacity, blur, padding. - [ ] T18 Terminal rows: scrollback, Option as Alt, copy on select. ## 11. Background blur diff --git a/tasks/reviews.md b/tasks/reviews.md index cef71e8..0611392 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -86,3 +86,8 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, - Round 1, 3e1535e: FAIL. The shell check asked only for an execute bit, so a file the running user may not run, as 0641 or an execute-deny ACL, saved and then failed every new session; a bare name counted relative PATH folders, which hang on each session's own folder, so the check and the start could find different programs. Fixed in 3c51b01: the check asks access(X_OK), and a bare name looks only in PATH's full folders; a session runs the full path the check found. - Round 2, 3c51b01: FAIL. On Windows the .exe candidate replaced an explicit extension, so review.com saved and review.exe ran; a program found at a path not in UTF-8 saved, though the start takes UTF-8 and refused it. Fixed in 9e69288: .exe joins only a name without an extension; the shared resolver returns the program as UTF-8 text and refuses a match that is not, before the save. - Round 3, 9e69288: PASS. + +## T17 + +- Round 1, f2cc16f: FAIL. The font picker saved a family gpui cannot load, such as Apple Color Emoji, which has no m, and the terminal drew with a fallback without a word; after a refused save a number field kept the refused draft, so once a later save cleared the message the field and the settings disagreed. Fixed in ee37018: a font saves, and a settings file starts, only when gpui loads it as the terminal draws it, and the terminal draws with no other font; numbers save on commit; a refusal resets the number fields and the font picker to the settings. +- Round 2, ee37018: PASS.