From 508a16f16ad80b433086f933ae6a68e80feb218d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Mon, 19 Oct 2026 17:48:07 -0400 Subject: [PATCH] T60: round 2 of its review --- tasks/reviews.md | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/reviews.md b/tasks/reviews.md index 8461cf0..6e085cc 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -306,3 +306,4 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, ## T60 - Round 1, cb32f00: FAIL. On macOS the order, bold, italic, ligatures, icons, old files, refusals, add, change and cancel all held; but removing the row whose input held the focus left the removed family in it, and Enter saved it over the next family; and on Linux gpui's cosmic-text path carries the fallback a character took into the next while it covers it, so `क中` drew 中 in the second fallback. Fixed in 5f8ea89: a removal drops that row's input and the focus; the Linux path is gpui's, kept for its shaping clusters, and the owner chose to record it. +- Round 2, 5f8ea89: FAIL. Round 1's removal case and removals first, middle, last, in sequence, then adds and cancels held, and the Linux record was true; but the pickers were keyed by place, so after a removal moved the inputs, the picker state of the second row, listening to the input now first, wrote PingFang SC into it at a blur, and Enter saved `[PingFang SC, PingFang SC]`. Fixed in 5d131e5: each picker is keyed by its input's entity.