From 65bb4d3456edb37f0f0d37a273b7f60e2c948260 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 15 Oct 2026 15:15:15 -0400 Subject: [PATCH] T24: the icon SVGs name their parts as groups, not comments, and draw the same pixels; mac-app.sh cuts the version at cargo pkgid's last # or @, as a clone in a folder named elyterminal prints no @, and stops when none is left; AGENTS.md says the macOS icon holds a copy of the figure --- AGENTS.md | 2 +- assets/icons/elyterminal-macos.svg | 115 ++++++++++++++++------------- assets/icons/elyterminal.svg | 115 ++++++++++++++++------------- scripts/mac-app.sh | 3 +- 4 files changed, 127 insertions(+), 108 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 3729a10..dc20e8b 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -33,7 +33,7 @@ ELYTerminal. A terminal on GPUI and Ely components. `PRD.md` says what it does; - `assets/shell-integration`: ELYTerminal's own scripts (not Ghostty's, which are GPL): zsh through `ZDOTDIR`, bash through `--rcfile`, fish through `XDG_DATA_DIRS`, PowerShell through `-NoExit -Command`. Each prompt sends OSC 7 and, except in fish, whose `fish_title` stays, a title. - `assets/fonts`: JetBrains Mono 2.304's bold and italic faces (OFL; Ely bundles regular), and Nerd Fonts 3.5.1's JetBrains Mono NF Mono Regular, which draws icons a font lacks. - `assets/themes`: Ghostty theme files copied verbatim from iTerm2-Color-Schemes (MIT, its `LICENSE` beside them). -- `assets/icons`: the icon, an original figure, Ely, holding a terminal: `elyterminal-macos.svg` on macOS's rounded square, `elyterminal.svg` the figure alone, for Windows and Linux. +- `assets/icons`: the icon, an original figure, Ely, holding a terminal: `elyterminal-macos.svg` on macOS's rounded square, `elyterminal.svg` the figure alone, for Windows and Linux; the macOS file holds a copy of the figure's markup, so an edit to the figure is made in both. ## Rules diff --git a/assets/icons/elyterminal-macos.svg b/assets/icons/elyterminal-macos.svg index 980c277..c4baafc 100644 --- a/assets/icons/elyterminal-macos.svg +++ b/assets/icons/elyterminal-macos.svg @@ -21,63 +21,72 @@ - + - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/assets/icons/elyterminal.svg b/assets/icons/elyterminal.svg index 13c18bb..3c060e7 100644 --- a/assets/icons/elyterminal.svg +++ b/assets/icons/elyterminal.svg @@ -1,60 +1,69 @@ - + - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/scripts/mac-app.sh b/scripts/mac-app.sh index 212d850..48397a6 100755 --- a/scripts/mac-app.sh +++ b/scripts/mac-app.sh @@ -4,7 +4,8 @@ set -eu cd "$(dirname "$0")/.." cargo build --release --locked version=$(cargo pkgid) -version=${version##*@} +version=${version##*[#@]} +case $version in [0-9]*) ;; *) echo "mac-app: cargo pkgid names no version" >&2; exit 1 ;; esac out=target/release app=$out/ELYTerminal.app work=$(mktemp -d)