ZacharyZhang-NY/ELYTerminal
1
8 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 7 Wiki Activity

T31: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m1s
Details
CI / platforms (windows-latest) (push) Successful in 1m26s
Details
CI / macos (push) Successful in 11m51s
Details

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-16 05:07:23 -04:00
1 parent 2a1060ce48
commit 9a0c0d9dbb
2 files changed
+5 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tasks/reviews.md
+4
View File
@@ -150,3 +150,7 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict,
- Round 1, 1bf420c: FAIL. On X11 a maximized window, minimized, wrote the screen's size, since gpui's X11 window calls a maximized window unmaximized while it is hidden; and the window could be dragged under the 100 by 100 the settings keep, so a smaller size was refused and lost. Fixed in 2f58a06: a hidden window keeps the size from before, and the window is no smaller than 100 by 100.
- Round 2, 2f58a06: FAIL. A size the window took just before something covered it was skipped while it was hidden and never read again once it showed. Fixed in 9729d24: a window that shows again is read again; and the window opens centered at whole points, since macOS grew a window whose centered edge fell on a half point by a point, so a kept 900 by 600 had opened at 900 by 601.
- Round 3, 9729d24: PASS. The reviewer replayed the cover on macOS through gpui and AppKit, against the parent too, and saw the size kept once shown and the restart open at it; the window opened at its kept size and a move wrote nothing; on X11 a maximized, minimized and restored window and a resize minimized at once kept the right size, and the 100 by 100 minimum held. CI runs 993 on 1bf420c and 995 on 2f58a06 passed on macOS, Ubuntu and Windows; run 996 on 9729d24 passed on Ubuntu and Windows.
## T31
- Round 1, 4364802 and 2a1060c, with release v0.1.2: PASS. The reviewer compared `Cargo.lock` with its parent, where only elyterminal moved to 0.1.2; matched the 112 files of the source the builds came from to the tag byte for byte; downloaded the three files anonymously against their SHA-256s; checked the disk image's notarization and its app's signature, the zip's icon, manifest and imports, and the tarball's glibc 2.35; and ran the downloaded macOS app with herdr 0.9.5: the folder followed herdr's focus, and the window reopened at its kept 923 by 617. CI run 1000 on 4364802 passed on macOS, Ubuntu and Windows before the release was published; Release run 1001 built the notarized disk image.