From b4750e61c96ad23c63fd206c82218aa5248c859c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Wed, 14 Oct 2026 12:44:36 -0400 Subject: [PATCH] T05: reviewed, ticked --- TASKS.md | 2 +- tasks/reviews.md | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/TASKS.md b/TASKS.md index 421bf02..b4b6c2c 100644 --- a/TASKS.md +++ b/TASKS.md @@ -17,7 +17,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co ## 5. Terminal engine - [x] T04 PTY: spawn through alacritty's event loop, OSC 7 tap on the reader, child id, events to the app; tests. -- [ ] T05 Shell integration for zsh, bash, fish, PowerShell, injected at launch; tests that zsh and bash report their folder. +- [x] T05 Shell integration for zsh, bash, fish, PowerShell, injected at launch; tests that zsh and bash report their folder. - [ ] T06 Terminal view: frame from the grid, colors and styles, wide and combining cells, cursor shapes and blink, font, line height, padding, resize. - [ ] T07 Box drawing and block elements painted as geometry; tests. - [ ] T08 Keys: xterm encoding, modes, Option as Alt, kitty keyboard protocol, IME; tests. diff --git a/tasks/reviews.md b/tasks/reviews.md index f328b9c..7c270c4 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -22,3 +22,8 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, - Round 2, 96ae85b: FAIL. The permission check raced alacritty's chdir, whose result alacritty ignores; closing a live pty logged nothing. Fixed in fff436c: ELYTerminal's own Unix pty, a checked chdir in pre_exec that fails the spawn, closing and hung-up logs with a test. - Round 3, fff436c: FAIL. Drop waited on the program while holding the master, so a program ignoring SIGHUP never ended. Fixed in 0e7f309: the master closes before the wait; a test that traps HUP went red, then green. - The review cap of three rounds is reached. The round-3 fix stands on its red-green test, not a fourth round. + +## T05 + +- Round 1, dfaf378: FAIL. fish searched /fish/fish, so its script never loaded (fish 4 sends OSC 7 itself and hid it); PowerShell's Restricted policy would block the script; control bytes in a folder name broke OSC 7; bash and PowerShell prompts reset $?; install swallowed read errors. Fixed in c2da9dd, each break shown red in a scratch copy. +- Round 2, c2da9dd: PASS.