ZacharyZhang-NY/ELYTerminal
1
8 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 7 Wiki Activity

T24: reviewed, ticked
CI / platforms (ubuntu-24.04) (push) Successful in 1m26s
Details
CI / platforms (windows-latest) (push) Successful in 2m19s
Details
CI / macos (push) Successful in 11m32s
Details

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-15 15:41:04 -04:00
1 parent 65bb4d3456
commit bc2059949a
3 files changed
+8 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tasks/acceptance.md
+3 -3
View File
@@ -23,7 +23,7 @@ What no check reached: no one has looked at the window on Windows, which CI buil
| Ely by pinned rev; gpui and gpui_platform from `gpui-pre` at Ely's version | T01 | `Cargo.toml`: Ely `a2cb531`, `gpui-pre` `=0.3.8` | Pass |
| `alacritty_terminal` 0.26 | T04 | `=0.26.0` | Pass |
| Logs through `log` to stderr, `RUST_LOG` sets the level, no log setting | T01 | `src/main.rs`; no such field in `Settings` | Pass |
| CI on Gitea Actions: macOS builds, tests and lints; Ubuntu and Windows build and test | T01, T23 | `.github/workflows/ci.yml`; run 919 on `09930c2`, see the CI notes | Pass |
| CI on Gitea Actions: macOS builds, tests and lints; Ubuntu and Windows build and test | T01, T23 | `.github/workflows/ci.yml`; run 926 on `65bb4d3`, see the CI notes | Pass |
| Private repo; no credential in any file or commit | T01 | T22's review scanned the tree and its 398 reachable objects: 0 hits; T23's scans for the Gitea token and the runners' SSH details: 0 hits | Pass |
## 3. Settings model and storage
@@ -132,7 +132,7 @@ What no check reached: no one has looked at the window on Windows, which CI buil
|---|---|---|
| Each task ticked with a passing review | each task is ticked only after its review, as `tasks/reviews.md` records; T04 and T10 reached the three-round cap without a passing round, their last fixes standing on red-green tests | Partial |
| `scripts/check.sh` passes | macOS: 135 tests, clippy, fmt, 500 lines; Linux in Colima: 138 tests, clippy | Pass |
| CI green on macOS, Ubuntu and Windows | run 919 on `09930c2`: all three jobs pass; see the CI notes below | Pass |
| CI green on macOS, Ubuntu and Windows | run 926 on `65bb4d3`: all three jobs pass; see the CI notes below | Pass |
## 14. Icon and the macOS app
@@ -154,7 +154,7 @@ A clippy run for `x86_64-pc-windows-msvc` on macOS, with stand-ins for the MSVC
Run 907 then failed the PowerShell test on macOS: it typed its probe right after the first folder report, which pwsh 7.6.6 sends before PSReadLine reads its first key, and the line was echoed, never run. The shell tests now type a line only once the line editor reads raw keys.
Run 919, on `09930c2`, passed all three jobs: macOS ran `scripts/check.sh` (135 tests, the fonts check, clippy, fmt, the 500-line rule) and the build; Ubuntu ran 138 tests and the build; Windows ran 113 tests and the build, without the Unix-only pty and shell tests.
Run 926, on `65bb4d3`, passed all three jobs: macOS ran `scripts/check.sh` (135 tests, the fonts check, clippy, fmt, the 500-line rule) and the build; Ubuntu ran 138 tests and the build; Windows ran 113 tests and the build, without the Unix-only pty and shell tests.
## The owner's checks