From c0a9eb3c984f3eed387229b42abed4bc3a87a7c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 15 Oct 2026 15:07:26 -0400 Subject: [PATCH] T23: reviewed, ticked --- TASKS.md | 2 +- tasks/reviews.md | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/TASKS.md b/TASKS.md index 80fd69c..9542115 100644 --- a/TASKS.md +++ b/TASKS.md @@ -59,4 +59,4 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co ## 13. Acceptance -- [ ] T23 End-to-end checks, README, acceptance table, CI green on three platforms. +- [x] T23 End-to-end checks, README, acceptance table, CI green on three platforms. diff --git a/tasks/reviews.md b/tasks/reviews.md index 3f26a54..0126a90 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -112,3 +112,7 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, - Round 1, 5ee67bd: FAIL. Edit's Copy, Paste and Select All named the terminal's own actions, so with find, a settings field or the commit field in focus gpui disabled them and a menu press did nothing; Select All took a space under a combining mark for a blank and dropped the mark at either end; two new comments ran long. Fixed in 37220a7: Ely a2cb531, approved by the user, exports its text input's Copy, Cut, Paste and SelectAll, which the terminal and the menu now name; a cell with a mark counts as a character; every new comment is one short line. - Round 2, 37220a7: PASS. + +## T23 + +- Round 1, e3b5cfb..82bdbaf: PASS. The owner's checks on the release build found three faults, fixed in 09930c2 before the review: on macOS 27 gpui's Selection material drew no blur, the debug build lagged, and no button hid the side columns. CI went green once the owner let the runners be put right: fish and PowerShell on the macOS runner, rustup's proxies on the Windows runner, a Linux runner of the repository's own; on the way, run 907 caught the PowerShell test typing before the line editor read keys.