T45: round 2 fix: while herdr takes the mouse every link press is herdr's again, its rules with it, as its client and docs say: it keeps its panes' OSC 8 targets from the terminal so that it alone answers Ctrl-press, and opens web links only, so the terminal opening a file:// label it sees opened the wrong target; Shift with the press, herdr's named way past it, lets the terminal open what it sees, a file:// link too
CI / platforms (windows-latest) (push) Failing after 10s
CI / platforms (ubuntu-24.04) (push) Successful in 1m44s
CI / macos (push) Canceled after 0s

This commit is contained in:
ZacharyZhang-NY committed 2026-10-18 04:54:55 -04:00
1 parent af66a70947
commit c30bd51fba
6 files changed
+17 -30

No files matched your search

+1 -1
View File
@@ -114,7 +114,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co
## 24. Keys, links and Ely
- [x] T44 herdr's shortcuts work, which a user found dead: `cmd+shift+ctrl+[` and `]` on macOS, and the same keys as herdr reads them on Linux and Windows: under kitty's flags a key Shift makes a symbol of goes as its own key with Shift, the symbol its alternate, on macOS and Windows; on Windows keys go as win32-input-mode records, which ConPTY asks for and herdr reads; on Linux gpui keeps no key code, which the docs say.
- [ ] T45 Cmd-press on macOS, Ctrl-press on Windows and Linux opens the link under the pointer, which the owner asked for, wherever the terminal shows one: inside herdr, which wraps long URLs at its pane's edge and passes no OSC 8 target on, a web link's press goes to herdr, which opens its pane's link whole, Cmd heard as Ctrl on macOS, and a link of another kind the app opens itself.
- [ ] T45 Cmd-press on macOS, Ctrl-press on Windows and Linux opens the link under the pointer, which the owner asked for, wherever the terminal shows one: inside herdr, which wraps long URLs at its pane's edge and passes no OSC 8 target on, while herdr takes the mouse the press goes to herdr, which opens its pane's link whole, web links only, as herdr does, Cmd heard as Ctrl on macOS.
- [ ] T46 Ely peeks over the main window's top edge from behind it, which the owner asked for after the 0.1.3 film, with several faces and moves; a switch in Settings, Terminal, turns her off.
## 25. Release