T26: on Windows and Linux, which have no menu bar, a gear just inside the right toggle opens Settings; it sends OpenSettings through Window::dispatch_action, since App::dispatch_action inside the window's own click handler fails with only gpui's log line
CI / platforms (ubuntu-24.04) (push) Successful in 1m12s
CI / platforms (windows-latest) (push) Successful in 1m32s
CI / macos (push) Successful in 13m12s

This commit is contained in:
ZacharyZhang-NY committed 2026-10-15 19:04:41 -04:00
1 parent 0f87676ae2
commit c316d271a2
6 files changed
+22 -7

No files matched your search

+1
View File
@@ -106,6 +106,7 @@ What no check reached: no one has looked at the window on Windows, which CI buil
| PRD line | Task | Evidence | Status |
|---|---|---|---|
| Cmd-, opens it; categories left, rows right; changes apply at once and save | T16 | T16 review | Pass |
| On Windows and Linux, a gear in the title bar opens it too | T26 | on X11 under Xvfb with xfwm4, xdotool's click on the gear, just inside the right toggle, opened the 900×640 Settings window ("settings: the window opens"), after a click on + opened a session; sent through `App::dispatch_action`, the same click had opened nothing; the owner has not yet clicked it on Windows | Partial |
| General: Shell, Start in | T16 | `settings::tests` | Pass |
| Appearance: theme grids, dark theme, font, size, line height, ligatures, cursor and preview, opacity, blur, padding | T17 | T17 review | Pass |
| Terminal: scrollback, Option as Alt (macOS), copy on select | T18 | T18 review | Pass |