From ccbea6a7a074414d6aa425403dc43488f5939feb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Wed, 14 Oct 2026 17:59:31 -0400 Subject: [PATCH] T11: reviewed, ticked --- TASKS.md | 2 +- tasks/reviews.md | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/TASKS.md b/TASKS.md index ff60e49..2df9e3d 100644 --- a/TASKS.md +++ b/TASKS.md @@ -26,7 +26,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co ## 6. Main window and layout -- [ ] T11 `ColumnShell` with sessions, terminal and right columns; toggles kept in settings; window title; a transparent title bar over the window's background, as Ghostty's. +- [x] T11 `ColumnShell` with sessions, terminal and right columns; toggles kept in settings; window title; a transparent title bar over the window's background, as Ghostty's. ## 7. Sessions panel diff --git a/tasks/reviews.md b/tasks/reviews.md index 5e0bb6a..5df2bb4 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -54,3 +54,8 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, - Round 1, 4d8788f: FAIL. Matches went stale after a resize or a scrollback trim; the current match kept its index, not its line; alacritty's search read no combining marks; whole word used ASCII edges; a reset left the old title. Fixed in 1c21dfd: find runs Ely's find_all on the grid's shown text (marks, hidden cells blank, wrapped rows joined, Unicode words); output, resizes and settings changes search again; the current match follows its line; a reset replays the title. - Round 2, 1c21dfd: FAIL. Following was quadratic on a long line (60 s on a million characters); text appended to the current line moved the current match; a reset inside a synchronized update kept the old title. Fixed in 11b2ce6: one pass, a forward walk and line ends found once, guarded by a timed test; identical lines rank first, then lines grown or cut, then line and column; a cleared or trimmed history moves no line; the title replays on CursorBlinkingChange, in the parser's order. - Round 3, 11b2ce6: FAIL. With two identical lines, growing the current one moved the match to its twin. The three-round cap reached: fixed in 39761d9 on a red-green test, a line kept, grown or cut ranks first when held under the same line above or in its place. The reviewer's round 2 and 3 scenario records replayed with fresh homes, focus and long-line cases aside, all as expected; three mutations of the rule each fail a test. + +## T11 + +- Round 1, 34ce046: FAIL. A press on a blank column or a header gave focus to the focus root, below which the Workspace key context and its toggle actions sat, so Cmd-B and Cmd-Alt-B did nothing. Fixed in 0de9e15: the context and its actions sit on the outermost element, above ResizeBorder and the focus root; the four press-then-toggle cases hide both columns and save both flags. +- Round 2, 0de9e15: PASS.