From fdb1caa26e1a0545bb12246cb08581a9295544f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Wed, 14 Oct 2026 15:05:32 -0400 Subject: [PATCH] T08: reviewed, ticked --- TASKS.md | 2 +- tasks/reviews.md | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/TASKS.md b/TASKS.md index 8438021..7d801a0 100644 --- a/TASKS.md +++ b/TASKS.md @@ -20,7 +20,7 @@ Progress truth. Top to bottom, one at a time. A task is ticked only after its co - [x] T05 Shell integration for zsh, bash, fish, PowerShell, injected at launch; tests that zsh and bash report their folder. - [x] T06 Terminal view: frame from the grid, colors and styles, wide and combining cells, cursor shapes and blink, font, line height, padding, resize. - [x] T07 Box drawing, block elements and powerline shapes (U+E0B0–E0B7) painted as geometry; tests. -- [ ] T08 Keys: xterm encoding, cursor mode, Option as Alt, kitty keyboard protocol, IME; tests. +- [x] T08 Keys: xterm encoding, cursor mode, Option as Alt, kitty keyboard protocol, IME; tests. - [ ] T09 Mouse: selection, mouse reporting, wheel and scrollback, clipboard, copy on select, OSC 52, links; tests. - [ ] T10 Focus reporting, title, silent bell, scrollback limit, find. diff --git a/tasks/reviews.md b/tasks/reviews.md index 2338fcb..13337e1 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -37,3 +37,8 @@ Each task gets at most three codex rounds. Each round: the commit, the verdict, - Round 1, 387bfa1: FAIL. Dim geometry brightened where pieces overlapped (gpui blends each quad and path triangle on its own); a combining mark sent its drawn base back to the font, thicker and past the cell. Fixed in 2804aa6: overlaps cut from rects, strokes turned into polygons, the cross cut around its first band, a drawn base drawn under its marks; pixels of the dim row checked, no value above the dim color. - Round 2, 2804aa6: PASS. + +## T08 + +- Round 1, 25365a9: FAIL. Ely's focus bindings took F6 and Shift-F6; any kitty flag forced disambiguation; IME commits ignored kitty; macOS repeats routed through AppKit's commands went out as presses; Cmd combos never reached kitty; a stray key.zig of 876 lines slipped past the line rule. Fixed in 11d7a30: NoAction bindings under Terminal; each flag reshapes only what it names; Cmd is Super, bit 8; repeats read from AppKit's event; a local monitor hands Command key-ups to the view; key.zig out; the line rule reads every text file. The IME finding was answered: kitty's keys.c and Ghostty's encoder send commits as UTF-8 under every flag. Mutations of the encoder shown red in a scratch copy. +- Round 2, 11d7a30: PASS.