diff --git a/scripts/check.sh b/scripts/check.sh index 092386c..9b8ee8c 100755 --- a/scripts/check.sh +++ b/scripts/check.sh @@ -6,7 +6,7 @@ cargo clippy --all-targets --features test-support -- -D warnings cargo test --lib --features test-support --quiet # Ely beside the newest GPUI Kit: a release that moves Kit's gpui pin fails to resolve here. kit="--manifest-path compat/kit/Cargo.toml" -newest=$(cargo search gpui-kit --limit 1 | sed -n 's/^gpui-kit = "\([^"]*\)".*/\1/p') +newest=$(cargo search gpui-kit --limit 1 --color never | sed -n 's/^gpui-kit = "\([^"]*\)".*/\1/p') [ -n "$newest" ] || { echo "crates.io named no gpui-kit release" >&2; exit 1; } cargo generate-lockfile $kit cargo update $kit -p gpui-kit --precise "$newest" diff --git a/tasks/kit.md b/tasks/kit.md index e9ef2c0..126fe73 100644 --- a/tasks/kit.md +++ b/tasks/kit.md @@ -28,3 +28,4 @@ One line per item: what changed, what stayed and why, review rounds. - K03: `init` loads every file Ely bundles (318, Plex among them) through the app's source and fails naming the first it cannot; an icons-only source like Kit's passed the old one-icon check and fails now. `Assets::before(other)` serves Ely's paths first and the rest from `other`, its errors passing through. Docs and AGENTS.md say so. Review: 1 round. - K04: `compat/kit`, its own workspace, opens Ely's root scope inside Kit's `Root` and tests Tab through both libraries in each `init` order (red with K02 undone), Kit's dialog from an Ely button by key and by pointer, Ely's dialog over Kit's fields, and one asset source for both. `check.sh` resolves it afresh and holds `gpui-kit` to the newest release, so a Kit release on another gpui fails resolution naming `gpui-pre` (shown with Kit 0.7.0). Review: 2 rounds. - K05: the site's GPUI Kit guide (`/docs/gpui-kit`): dependencies, the start in four steps, focus, two themes, the inspector; the README points to it. `compat/kit/examples/start.rs` is a whole app, compiled by `check.sh` and run on Windows, where both libraries draw in one window. The guide says an app's Cargo keeps the newest Kit that shares Ely's GPUI, and names no unreleased Kit feature. Review: 2 rounds. +- K04, reopened: CI's macOS job colors Cargo's output, so `cargo search` hid the version from `sed` and `check.sh` stopped there; the search now passes `--color never` (red with `CARGO_TERM_COLOR=always`, green with the flag). Review: round 3.