ZacharyZhang-NY/Ely-GPUI-Components
1
1 Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

T48j Docs · Internationalization passes review

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-01 13:22:35 -04:00
1 parent a1203af405
commit 02c2d9dfcd
3 files changed
+3 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

TASKS.md
+1 -1
View File
@@ -173,7 +173,7 @@ Per-component lines live in `tasks/`. Tags there:
- [x] T48g Docs · Motion: durations, reduced motion, springs, motion from a change - [x] T48g Docs · Motion: durations, reduced motion, springs, motion from a change
- [x] T48h Docs · Icons, fonts and assets: `Assets`, `IconName`, adding icons, the embedded fonts, file icons - [x] T48h Docs · Icons, fonts and assets: `Assets`, `IconName`, adding icons, the embedded fonts, file icons
- [x] T48i Docs · Overlays: what draws over the page, dialogs, popovers, toasts - [x] T48i Docs · Overlays: what draws over the page, dialogs, popovers, toasts
- [ ] T48j Docs · Internationalization: the `I18n` global, catalogs, right-to-left - [x] T48j Docs · Internationalization: the `I18n` global, catalogs, right-to-left
- [ ] T48k Docs · WebAssembly: the web gallery build, its URL, the host protocol, what stays native - [ ] T48k Docs · WebAssembly: the web gallery build, its URL, the host protocol, what stays native
- [ ] T48l Docs · Testing: the `test-support` feature, frames, clocks and reduced motion in tests - [ ] T48l Docs · Testing: the `test-support` feature, frames, clocks and reduced motion in tests
- [ ] T48m Docs · E2E: the Docs routes, rail, list, previous and next, and code blocks under Playwright - [ ] T48m Docs · E2E: the Docs routes, rail, list, previous and next, and code blocks under Playwright
frontend/src/docs/i18n.md
+1 -1
View File
@@ -27,7 +27,7 @@ Ely's components take their words from the app: a `Button`'s label, a `Dialog`'s
## Right to left ## Right to left
He-IL reads right to left. `direction.row(element)` lays a flex row from the reading side, and `direction.align(element)` aligns text to that side. The he-IL locale reads right to left. `direction.row(element)` lays a flex row from the reading side, and `direction.align(element)` aligns text to that side.
GPUI sets no paragraph direction, so a line runs the way its first strong letter does. `text` leads a right-to-left message with a right-to-left mark, so its words suit labels, not a field's value. `number` leads a right-to-left minus with a left-to-right mark, as CLDR does. GPUI wraps right-to-left lines in the wrong order, so keep such text on one line, an `Ellipsis`. GPUI sets no paragraph direction, so a line runs the way its first strong letter does. `text` leads a right-to-left message with a right-to-left mark, so its words suit labels, not a field's value. `number` leads a right-to-left minus with a left-to-right mark, as CLDR does. GPUI wraps right-to-left lines in the wrong order, so keep such text on one line, an `Ellipsis`.
tasks/reviews.md
+1
View File
@@ -340,3 +340,4 @@
| T48h | 1 | PASS | note taken: init checks icons/check.svg | | T48h | 1 | PASS | note taken: init checks icons/check.svg |
| T48i | 1 | FAIL | said tooltips and toasts take focus; gave a centered dialog a close button | | T48i | 1 | FAIL | said tooltips and toasts take focus; gave a centered dialog a close button |
| T48i | 2 | PASS | | | T48i | 2 | PASS | |
| T48j | 1 | PASS | note taken: the he-IL tag keeps its case |