Column shell: a drag sets off from the wider of the width drawn and the owner's, so a column a short shell squeezes moves with the pointer, where it jumped back against it, and a drag with no sideways move changes no width, where it wrote the squeezed one
CI / platforms (ubuntu-24.04) (push) Waiting to run
CI / site (push) Successful in 31s
CI / platforms (windows-latest) (push) Successful in 5m2s
CI / crate (push) Failing after 13m0s

This commit is contained in:
ZacharyZhang-NY committed 2026-10-16 20:57:32 -04:00
1 parent 005faefd5d
commit 0b4848bb2a
3 files changed
+46 -4

No files matched your search

+37 -1
View File
@@ -9,6 +9,7 @@ use crate::theme::{Platform, Theme};
/// Two set columns round a filling one; this view keeps their widths.
struct Sided {
platform: Platform,
width: Pixels,
widths: [Pixels; 2],
heard: Vec<Pixels>,
}
@@ -31,7 +32,7 @@ impl Render for Sided {
},
)
};
div().w(px(1000.0)).h(px(400.0)).flex().flex_col().child(
div().w(self.width).h(px(400.0)).flex().flex_col().child(
ColumnShell::new("shell")
.platform(self.platform)
.column(side("left", 0))
@@ -48,6 +49,7 @@ fn sided(
) -> (Entity<Sided>, &mut VisualTestContext) {
let (view, cx) = cx.add_window_view(|_, _| Sided {
platform,
width: px(1000.0),
widths,
heard: Vec::new(),
});
@@ -166,3 +168,37 @@ fn a_resizing_column_needs_a_border_toward_a_filling_one(cx: &mut TestAppContext
let (_, cx) = cx.add_window_view(|_, _| Unfilled);
cx.run_until_parked();
}
/// A short shell squeezes both columns; a drag moves a border with the pointer, from the owner's width.
#[gpui::test]
fn a_squeezed_column_drags_from_the_owner_s_width(cx: &mut TestAppContext) {
cx.update(Theme::init);
let (view, cx) = cx.add_window_view(|_, _| Sided {
platform: Platform::Linux,
width: px(700.0),
widths: [px(350.0), px(350.0)],
heard: Vec::new(),
});
cx.run_until_parked();
let left = column(0, cx);
assert!(left.size.width < px(350.0), "{left:?} is squeezed");
let border = |ix: usize, cx: &mut VisualTestContext| {
let name = ["column-shell-border-0", "", "column-shell-border-2"][ix];
cx.debug_bounds(name).expect("a border").center()
};
drag(border(0, cx), px(0.0), cx);
assert_eq!(heard(&view, cx), None, "a drag with no sideways move");
drag(border(0, cx), px(20.0), cx);
assert_eq!(heard(&view, cx), Some(px(370.0)));
assert!(
column(0, cx).right() > left.right(),
"the left border moves right"
);
let right = column(2, cx);
drag(border(2, cx), px(-20.0), cx);
assert_eq!(heard(&view, cx), Some(px(370.0)));
assert!(
column(2, cx).left() < right.left(),
"the right border moves left"
);
}