T14b Tables: resize, reorder, visibility, pinning, expansion, grouping, inline edit, toolbar, filter and sort builders (review pending: codex 401)

This commit is contained in:
ZacharyZhang-NY committed 2026-09-25 20:30:41 -04:00
1 parent dcd988e4b8
commit 0bfde95888
17 files changed
+2292 -420

No files matched your search

+116 -1
View File
@@ -1,7 +1,7 @@
use std::{cell::RefCell, rc::Rc};
use gpui::{
Context, IntoElement, Modifiers, Render, SharedString, Styled, TestAppContext,
Context, IntoElement, Modifiers, ParentElement, Render, SharedString, Styled, TestAppContext,
VisualTestContext, Window, point, px,
};
@@ -67,3 +67,118 @@ fn boxes_toggle_shift_takes_a_range_and_the_header_takes_all(cx: &mut TestAppCon
settle(cx);
assert!(picks(&seen).is_empty(), "a full one clears");
}
/// Six rows in two groups, measured as they draw.
struct Grouped(Rc<std::cell::Cell<gpui::Pixels>>);
impl Render for Grouped {
fn render(&mut self, _: &mut Window, _: &mut Context<Self>) -> impl IntoElement {
let tall = self.0.clone();
let rows: Vec<Row> = (0..6)
.map(|ix| {
Row::new(
format!("r{ix}"),
[
if ix < 4 { "Europe" } else { "Asia" }.into(),
format!("Row {ix}").into(),
],
)
})
.collect();
crate::primitives::Measure::new("measure", move |bounds, _, _| tall.set(bounds.size.height))
.w(px(400.0))
.child(
DataTable::new(
"grouped",
[Column::new("region", "Region"), Column::new("name", "Name")],
)
.rows(rows)
.group_by("region"),
)
}
}
#[gpui::test]
fn a_press_on_a_group_folds_its_rows(cx: &mut TestAppContext) {
cx.update(Theme::init);
let tall = Rc::new(std::cell::Cell::new(gpui::Pixels::ZERO));
let seen = tall.clone();
let (_, cx) = cx.add_window_view(|_, _| Grouped(seen));
settle(cx);
let open = tall.get();
cx.simulate_click(point(px(60.0), px(54.0)), Modifiers::none());
settle(cx);
assert_eq!(
open - tall.get(),
px(36.0 * 4.0),
"Europe's four rows fold away"
);
}
/// Two rows whose names edit in place and whose detail opens; it keeps what it hears.
struct Editable(Rc<RefCell<Vec<String>>>);
impl Render for Editable {
fn render(&mut self, _: &mut Window, _: &mut Context<Self>) -> impl IntoElement {
let (heard, opened) = (self.0.clone(), self.0.clone());
DataTable::new("editable", [Column::new("name", "Name").editable()])
.rows(vec![
Row::new("a", ["Ada".into()]),
Row::new("b", ["Alan".into()]),
])
.detail(move |key, _, _| {
opened.borrow_mut().push(format!("detail {key}"));
gpui::div().h(px(40.0)).into_any_element()
})
.on_edit(move |row, column, text, _, _| {
heard
.borrow_mut()
.push(format!("edit {row} {column} {text}"))
})
.w(px(400.0))
}
}
#[gpui::test]
fn a_row_opens_its_detail_and_a_double_press_edits_a_cell(cx: &mut TestAppContext) {
cx.update(|cx| {
Theme::init(cx);
crate::forms::bind_keys(cx);
});
let heard = Rc::new(RefCell::new(Vec::new()));
let seen = heard.clone();
let (_, cx) = cx.add_window_view(|_, _| Editable(seen));
settle(cx);
cx.simulate_click(point(px(14.0), px(54.0)), Modifiers::none());
settle(cx);
assert_eq!(heard.borrow().last().map(String::as_str), Some("detail a"));
let name = point(px(120.0), px(54.0 + 36.0 + 40.0 + 24.0));
for count in [1, 2] {
cx.simulate_event(gpui::MouseDownEvent {
button: gpui::MouseButton::Left,
position: name,
modifiers: Modifiers::none(),
click_count: count,
first_mouse: false,
});
cx.simulate_event(gpui::MouseUpEvent {
button: gpui::MouseButton::Left,
position: name,
modifiers: Modifiers::none(),
click_count: count,
});
}
settle(cx);
cx.simulate_input("Alan Kay");
cx.simulate_keystrokes("enter");
settle(cx);
assert_eq!(
heard
.borrow()
.iter()
.filter(|line| line.starts_with("edit"))
.cloned()
.collect::<Vec<_>>(),
["edit b name Alan Kay"]
);
}