From 0eeeb2db155248c5b2cd8eb0b64c889f0ac94c3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 1 Oct 2026 12:36:39 -0400 Subject: [PATCH] =?UTF-8?q?T48e=20Docs=20=C2=B7=20Theme=20passes=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TASKS.md | 2 +- frontend/src/docs/theme.md | 4 ++-- tasks/reviews.md | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/TASKS.md b/TASKS.md index 69eab81..74c4421 100644 --- a/TASKS.md +++ b/TASKS.md @@ -168,7 +168,7 @@ Per-component lines live in `tasks/`. Tags there: - [x] T48b Docs · Introduction: what Ely is, the order to read, what is stable, a first example, license - [x] T48c Docs · Installation: Rust, the git dependencies, gpui_platform's fonts, runtime shaders, the gallery as a check, what `init` refuses - [x] T48d Docs · Getting started: an app from `init` to a window under a root `FocusScope`, with a Button -- [ ] T48e Docs · Theme: modes, tokens through `cx.theme()`, high contrast, color-blind safe charts, an owner's palette +- [x] T48e Docs · Theme: modes, tokens through `cx.theme()`, high contrast, color-blind safe charts, an owner's palette - [ ] T48f Docs · Focus and keyboard: Tab and Shift-Tab, the root scope, tab stops, the focus ring, overlays that take and give back focus - [ ] T48g Docs · Motion: durations, reduced motion, springs, motion from a change - [ ] T48h Docs · Icons, fonts and assets: `Assets`, `IconName`, adding icons, the embedded fonts, file icons diff --git a/frontend/src/docs/theme.md b/frontend/src/docs/theme.md index ed6a7d4..eaecfaf 100644 --- a/frontend/src/docs/theme.md +++ b/frontend/src/docs/theme.md @@ -13,7 +13,7 @@ Bring `ActiveTheme` into scope and call `cx.theme()` on `App`, or on a `Context` | `radius(Radius)` | `Sm` 4px, `Md` 6px, `Lg` 8px, `Xl` 12px, times `radius_scale`. | | `elevation(Elevation)` | Shadows for `Raised`, `Floating` and `Modal`; darker in dark mode. | | `control_height(ControlSize)` | `Sm` 24px, `Md` 28px, `Lg` 32px; 4px less under `Density::Compact`, 4px more under `Comfortable`. | -| `is_dark()`, `high_contrast()`, `color_blind_safe()` | The current switches. | +| `mode()`, `is_dark()`, `high_contrast()`, `color_blind_safe()` | The current mode and switches. | Sizes come back as `Rems`, so they follow the window's rem size. @@ -26,7 +26,7 @@ Sizes come back as `Rems`, so they follow the window's rem size. | `Theme::set_high_contrast(on, cx)` | Muted text and borders move further from the page, and glass turns opaque, in Ely's palettes. | | `Theme::set_color_blind_safe(on, cx)` | Chart hues that stay apart under protanopia, deuteranopia and tritanopia. | | `Theme::set_palette(mode, palette, cx)` | An owner's palette for one mode; `None` brings Ely's back. | -| `Theme::update(cx, edit)` | Edits the other fields: `density`, `font_scale`, `radius_scale`, `font_family`, `mono_family`, `reduced_motion`. | +| `Theme::update(cx, edit)` | Edits the other fields: `density`, `font_scale`, `radius_scale`, `font_family`, `mono_family`, `reduced_motion`, `platform`. | The color calls log at the `info` level, so a theme change shows in the app's log. diff --git a/tasks/reviews.md b/tasks/reviews.md index 041e4c0..0bff2b1 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -334,3 +334,4 @@ | T48c | 1 | FAIL | said Ely compiles the shaders when the app starts; a code span kept a trailing space | | T48c | 2 | PASS | | | T48d | 1 | PASS | note taken: the lead and the table both count four parts | +| T48e | 1 | PASS | notes taken: `mode()` in the read table, `platform` among update's fields |