From 157b6ba761660d4926937d7f778051d058d2b3ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Sun, 4 Oct 2026 00:52:22 -0400 Subject: [PATCH] =?UTF-8?q?Tasks=20=C2=B7=20T50g:=20chapter=2044=20accepte?= =?UTF-8?q?d,=20item=20by=20item?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TASKS.md | 2 +- tasks/ch44.md | 15 +++++++++++++++ tasks/reviews.md | 2 ++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/TASKS.md b/TASKS.md index 80a78b2..7f44794 100644 --- a/TASKS.md +++ b/TASKS.md @@ -184,7 +184,7 @@ Per-component lines live in `tasks/`. Tags there: - [x] T50d Rendering · Web: the story runs live on the site from the wasm gallery, checked in a browser - [x] T50e Rendering · Platforms: CI builds and tests the crate on Linux, macOS and Windows, arm64 and x86_64 - [x] T50f Rendering · Docs: a guide with an example `scripts/check.sh` compiles; AGENTS.md -- [ ] T50g Rendering · Acceptance: the checklist, item by item +- [x] T50g Rendering · Acceptance: the checklist, item by item ## T00 detail diff --git a/tasks/ch44.md b/tasks/ch44.md index 8825d59..40f9a5f 100644 --- a/tasks/ch44.md +++ b/tasks/ch44.md @@ -11,3 +11,18 @@ gpui at 1a28cff paints pixels three ways: `RenderImage` through `paint_image` on - [x] ZeroCopyTexture / SharedTextureView — `blocked`: only macOS's Metal renderer draws `paint_surface`, NV12 alone - [x] MetalSurface / OpenGLSurface / VulkanSurface / D3D11/D3D12Surface — `blocked`: gpui shares no device; a host renders offscreen and feeds `rendering::RenderSurface` - [x] 3D Scene / 3D Viewport → `media::ModelViewer` + +## T50g Acceptance + +| Asked | Done | Proof | +|---|---|---| +| Can a canvas or render surface be real on GPUI? | Yes, through `RenderImage`; nothing shares GPUI's device | gpui at 1a28cff: `paint_image`, `paint_surface` (NV12, Metal alone), no device hook; T50a review | +| List what can be added | Every draft entry judged above: build, alias, host or blocked | this file; PRD chapter 44 | +| Scope the owner chose | `RenderSurface` alone, chapter 44 | owner's answer, 2026-10-04 | +| Linux, macOS, Windows, arm64 and x86_64 | Lib tests pass on all six; the gallery builds on five and passes clippy on macOS arm64 | CI run 37177191793 on b85955a | +| Gallery example | Rendering page, its story in `stories.json` | ran on Linux: 720x360 in 22 ms, debug | +| WebAssembly on the website | The story runs live from the wasm gallery | headless shots light and dark; `e2e/live.spec.ts` fails when the surface never redraws | +| Docs | Rendering guide, `docs_render` compiled by `check.sh` | `e2e/docs.spec.ts` 24 passed | +| Reviews | Each item in a herdr pane, codex `gpt-6.1-sol` at `max` | `tasks/reviews.md` | +| Files at or under 500 lines | Largest new file 138 lines | `check.sh` | +| Not done | Site not deployed; section notes clip at the frame's right edge on every story | owner's call; seen on MapView too | diff --git a/tasks/reviews.md b/tasks/reviews.md index 280f5de..db65148 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -358,3 +358,5 @@ | T50e | 1 | PASS | run 37175728059: seven jobs green; 21 tests typed cmd- where init binds secondary- | | T50f | 1 | FAIL | AGENTS.md said a literal cmd- is no shortcut off macOS; gpui parses cmd- as the platform key everywhere | | T50f | 2 | PASS | | +| T50g | 1 | FAIL | the platforms row said the gallery builds on all six; macOS arm64 checks it with clippy | +| T50g | 2 | PASS | |