From 3001fe88de64164a51e256015d91b2db97e980c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 1 Oct 2026 12:30:09 -0400 Subject: [PATCH] =?UTF-8?q?T48d=20Docs=20=C2=B7=20Getting=20started=20pass?= =?UTF-8?q?es=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TASKS.md | 2 +- frontend/src/docs/getting-started.md | 6 +++--- tasks/reviews.md | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/TASKS.md b/TASKS.md index 35e3f8c..69eab81 100644 --- a/TASKS.md +++ b/TASKS.md @@ -167,7 +167,7 @@ Per-component lines live in `tasks/`. Tags there: - [x] T48a Docs · Frame: the Docs tab, `/docs/` and `/docs/$page/`, Markdown pages, the rail, the on-this-page list, previous and next, code blocks, light and dark, phone to desktop - [x] T48b Docs · Introduction: what Ely is, the order to read, what is stable, a first example, license - [x] T48c Docs · Installation: Rust, the git dependencies, gpui_platform's fonts, runtime shaders, the gallery as a check, what `init` refuses -- [ ] T48d Docs · Getting started: an app from `init` to a window under a root `FocusScope`, with a Button +- [x] T48d Docs · Getting started: an app from `init` to a window under a root `FocusScope`, with a Button - [ ] T48e Docs · Theme: modes, tokens through `cx.theme()`, high contrast, color-blind safe charts, an owner's palette - [ ] T48f Docs · Focus and keyboard: Tab and Shift-Tab, the root scope, tab stops, the focus ring, overlays that take and give back focus - [ ] T48g Docs · Motion: durations, reduced motion, springs, motion from a change diff --git a/frontend/src/docs/getting-started.md b/frontend/src/docs/getting-started.md index 6e63561..950fa8c 100644 --- a/frontend/src/docs/getting-started.md +++ b/frontend/src/docs/getting-started.md @@ -1,10 +1,10 @@ # Getting started -An Ely app is a GPUI app with three more parts: Ely's assets, one call to `init`, and a root `FocusScope` around each window's content. +An Ely app is a GPUI app with four more parts: Ely's assets, one call to `init`, a root `FocusScope` around each window's content, and colors from the theme. -## Four steps +## Four parts -| Step | Why | +| Part | Why | | --- | --- | | `gpui_platform::application().with_assets(Assets)` | Ely embeds its icons and fonts. `init` panics without them. | | `ely_gpui_component::init(cx)` | Call once, before any window. It registers the fonts, sets the theme, and binds Tab, Shift-Tab and the keys of text fields, the code editor, documents and, natively, the terminal. | diff --git a/tasks/reviews.md b/tasks/reviews.md index 5e37c17..041e4c0 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -333,3 +333,4 @@ | T48b | 1 | PASS | note taken: durations shorten to a millisecond | | T48c | 1 | FAIL | said Ely compiles the shaders when the app starts; a code span kept a trailing space | | T48c | 2 | PASS | | +| T48d | 1 | PASS | note taken: the lead and the table both count four parts |