Port · Build: Zed's gpui at 1a28cff
gpui and gpui_platform now come from Zed's repo by git at 1a28cff, the code gpui-pre 0.3.7 republishes, so the gallery can later build for the browser. gpui takes stacker, as 0.2.2 always did, and gpui_platform takes font-kit, without which macOS draws no text; runtime_shaders moves to gpui_platform. The API moved: focus, blur and Tab steps take cx, Corner is Anchor, shaped lines paint with an alignment, defer_draw takes a content mask, the inspector registers a factory, async updates return their value, and wrapped lines are shared, not cloned. Updates through a window context go through the window, so a closed window still ends them as it did. Where the new gpui behaves differently, Ely keeps its old intent. Holds and reveals under a resting pointer survive typing through gpui's input-modality-independent hover; previews the keyboard also moves keep the default, and the calendar's leave ignores a key press. Enter reaches a button inside the code editor, since gpui now arms a key click on the press. The event logger skips a lone modifier. A video and an image grid keep their shape in a flex column under taffy 0.13, as a picture does. AGENTS.md records the new stack and the rules this port changes; the rest of the old gpui and taffy rules are re-tested in T44c.
This commit is contained in:
1 parent
25b8a6f22c
commit
4c3ed1bbb9
199 files changed
+2513
-2643
No files matched your search
@@ -97,13 +97,15 @@ fn expire(
|
||||
let (weak, generation) = (state.downgrade(), state.read(cx).generation);
|
||||
window.spawn(cx, async move |cx| {
|
||||
cx.background_executor().timer(after).await;
|
||||
let cleared = weak.update(cx, |confirm, cx| {
|
||||
if confirm.generation == generation {
|
||||
clear(confirm);
|
||||
cx.notify();
|
||||
}
|
||||
let cleared = cx.update(|_, cx| {
|
||||
weak.update(cx, |confirm, cx| {
|
||||
if confirm.generation == generation {
|
||||
clear(confirm);
|
||||
cx.notify();
|
||||
}
|
||||
})
|
||||
});
|
||||
if let Err(error) = cleared {
|
||||
if let Err(error) = cleared.and_then(|inner| inner) {
|
||||
log::error!("confirm button: state gone before it expired: {error:#}");
|
||||
}
|
||||
})
|
||||
|
||||
+7
-4
@@ -53,10 +53,13 @@ impl RenderOnce for CopyButton {
|
||||
let weak = state.downgrade();
|
||||
let reset = window.spawn(cx, async move |cx| {
|
||||
cx.background_executor().timer(CONFIRM).await;
|
||||
if let Err(error) = weak.update(cx, |copied, cx| {
|
||||
copied._reset = None;
|
||||
cx.notify();
|
||||
}) {
|
||||
let cleared = cx.update(|_, cx| {
|
||||
weak.update(cx, |copied, cx| {
|
||||
copied._reset = None;
|
||||
cx.notify();
|
||||
})
|
||||
});
|
||||
if let Err(error) = cleared.and_then(|inner| inner) {
|
||||
log::error!("copy button: reset lost its state: {error:#}");
|
||||
}
|
||||
});
|
||||
|
||||
@@ -197,8 +197,8 @@ impl RenderOnce for SegmentedControl {
|
||||
.id(self.id.clone())
|
||||
.relative()
|
||||
.flex()
|
||||
.flex_grow()
|
||||
.flex_shrink()
|
||||
.flex_grow_1()
|
||||
.flex_shrink_1()
|
||||
.min_w(least * count as f32)
|
||||
.items_center()
|
||||
.child(measure_origin(state.clone(), Axis::Horizontal))
|
||||
|
||||
@@ -47,7 +47,7 @@ fn a_loading_button_ignores_presses_and_keeps_its_tab_stop(cx: &mut TestAppConte
|
||||
presses: 0,
|
||||
});
|
||||
let root = view.read_with(cx, |bench, _| bench.root.clone());
|
||||
cx.update(|window, _| window.focus(&root));
|
||||
cx.update(|window, cx| window.focus(&root, cx));
|
||||
press("tab", cx);
|
||||
press("enter", cx);
|
||||
assert_eq!(view.read_with(cx, |bench, _| bench.presses), 0);
|
||||
|
||||
Reference in new issue
Block a user