Port · Build: Zed's gpui at 1a28cff
gpui and gpui_platform now come from Zed's repo by git at 1a28cff, the code gpui-pre 0.3.7 republishes, so the gallery can later build for the browser. gpui takes stacker, as 0.2.2 always did, and gpui_platform takes font-kit, without which macOS draws no text; runtime_shaders moves to gpui_platform. The API moved: focus, blur and Tab steps take cx, Corner is Anchor, shaped lines paint with an alignment, defer_draw takes a content mask, the inspector registers a factory, async updates return their value, and wrapped lines are shared, not cloned. Updates through a window context go through the window, so a closed window still ends them as it did. Where the new gpui behaves differently, Ely keeps its old intent. Holds and reveals under a resting pointer survive typing through gpui's input-modality-independent hover; previews the keyboard also moves keep the default, and the calendar's leave ignores a key press. Enter reaches a button inside the code editor, since gpui now arms a key click on the press. The event logger skips a lone modifier. A video and an image grid keep their shape in a flex column under taffy 0.13, as a picture does. AGENTS.md records the new stack and the rules this port changes; the rest of the old gpui and taffy rules are re-tested in T44c.
This commit is contained in:
1 parent
25b8a6f22c
commit
4c3ed1bbb9
199 files changed
+2513
-2643
No files matched your search
+4
-4
@@ -36,9 +36,9 @@ impl RenderOnce for SkipLink {
|
||||
let shown = handle.is_focused(window);
|
||||
let theme = cx.theme();
|
||||
let (target, label) = (self.target, self.label.clone());
|
||||
let skip = move |window: &mut Window| {
|
||||
let skip = move |window: &mut Window, cx: &mut App| {
|
||||
log::info!("skip link {label:?}: focus to its target");
|
||||
window.focus(&target);
|
||||
window.focus(&target, cx);
|
||||
};
|
||||
let press = skip.clone();
|
||||
let pill = div()
|
||||
@@ -55,11 +55,11 @@ impl RenderOnce for SkipLink {
|
||||
.text_color(theme.colors.fg)
|
||||
.cursor_pointer()
|
||||
.child(self.label)
|
||||
.on_click(move |_, window, _| press(window));
|
||||
.on_click(move |_, window, cx| press(window, cx));
|
||||
div()
|
||||
.id(self.id.clone())
|
||||
.track_focus(&handle)
|
||||
.on_click(move |_, window, _| skip(window))
|
||||
.on_click(move |_, window, cx| skip(window, cx))
|
||||
.when(shown, |link| {
|
||||
link.child(raise(
|
||||
self.id.clone(),
|
||||
|
||||
@@ -209,7 +209,7 @@ fn focused(
|
||||
fn a_skip_link_leads_past_the_nav(cx: &mut TestAppContext) {
|
||||
let (view, cx) = page(cx);
|
||||
let root = view.read_with(cx, |page, _| page.root.clone());
|
||||
cx.update(|window, _| window.focus(&root));
|
||||
cx.update(|window, cx| window.focus(&root, cx));
|
||||
press("tab", cx);
|
||||
assert!(
|
||||
!focused(&view, |page| &page.nav[0], cx),
|
||||
@@ -237,7 +237,7 @@ fn a_skip_link_shows_only_while_focused(cx: &mut TestAppContext) {
|
||||
"at rest the nav takes it"
|
||||
);
|
||||
let root = view.read_with(cx, |page, _| page.root.clone());
|
||||
cx.update(|window, _| window.focus(&root));
|
||||
cx.update(|window, cx| window.focus(&root, cx));
|
||||
press("tab", cx);
|
||||
cx.simulate_click(spot, Modifiers::none());
|
||||
cx.run_until_parked();
|
||||
|
||||
@@ -206,14 +206,7 @@ mod shown {
|
||||
|
||||
#[test]
|
||||
fn text_sits_against_the_reading_side() {
|
||||
let side = |direction: Direction| {
|
||||
direction
|
||||
.align(div())
|
||||
.style()
|
||||
.text
|
||||
.as_ref()
|
||||
.and_then(|text| text.text_align)
|
||||
};
|
||||
let side = |direction: Direction| direction.align(div()).style().text.text_align;
|
||||
assert_eq!(side(Direction::Ltr), Some(gpui::TextAlign::Left));
|
||||
assert_eq!(side(Direction::Rtl), Some(gpui::TextAlign::Right));
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user