Forms, a11y · Checkbox, Switch, Radio, RadioGroup, Slider and Select name their role, label and state (#3)

A slider's thumb reports its value, the bounds it can reach and its orientation; a select's trigger its value, placeholder and whether its list is open; a disabled control says so in its description.
This commit is contained in:
ZacharyZhang-NY committed 2026-10-03 01:35:48 -04:00
1 parent ec586e371b
commit 875cdfdc9b
8 files changed
+71 -12

No files matched your search

+14 -3
View File
@@ -2,8 +2,8 @@ use std::rc::Rc;
use gpui::{
Animation, AnimationExt, AnyElement, App, ElementId, InteractiveElement, IntoElement,
MouseButton, ParentElement, RenderOnce, SharedString, StatefulInteractiveElement, Styled,
Window, div, prelude::*,
MouseButton, ParentElement, RenderOnce, Role, SharedString, StatefulInteractiveElement, Styled,
Toggled, Window, div, prelude::*,
};
use super::{
@@ -11,7 +11,7 @@ use super::{
options::{OnFlag, OnValues},
};
use crate::{
motion,
i18n, motion,
primitives::{Icon, IconName, tab_stop},
theme::{ActiveTheme, IconSize, Mix, Radius, TextSize},
};
@@ -152,8 +152,19 @@ impl RenderOnce for Checkbox {
} else {
theme.colors.fg
};
let toggled = match self.state {
CheckState::Off => Toggled::False,
CheckState::On => Toggled::True,
CheckState::Mixed => Toggled::Mixed,
};
div()
.id(self.id)
.role(Role::CheckBox)
.aria_toggled(toggled)
.when_some(self.label.clone(), |row, label| row.aria_label(label))
.when(self.disabled, |row| {
row.aria_description(i18n::text(cx, "state.unavailable", &[]))
})
.track_focus(&focus)
.flex()
.items_center()