T17 review fixes: hidden numbers draw, empty edits and read-only commands change nothing, hints stay in a ghost-cut row, the newest cursor leads, a composition undoes in one step, call keys carry their place, references count matches, trailing-space hits and **/ globs, name-only switcher marks, pin and remove stay on their button, settings show their places; decimals moves to typography::format

This commit is contained in:
ZacharyZhang-NY committed 2026-09-26 01:07:37 -04:00
1 parent 5545ce6458
commit 8ea952c6dc
20 files changed
+383 -85

No files matched your search

+6 -7
View File
@@ -9,7 +9,7 @@ use crate::{
buttons::{ToggleButton, ToggleItem},
primitives::{Icon, IconName, Severity},
theme::{ActiveTheme, ControlSize, IconSize, Radius, TextSize},
typography::Ellipsis,
typography::{Ellipsis, format},
};
/// A problem the tools found: where, how bad, what, and which tool said so.
@@ -116,14 +116,13 @@ impl RenderOnce for ProblemsPanel {
.count()
};
let filters = [
(Severity::Danger, "errors", "Error"),
(Severity::Warning, "warnings", "Warning"),
(Severity::Info, "notes", "Note"),
(Severity::Danger, "errors", ("Error", "Errors")),
(Severity::Warning, "warnings", ("Warning", "Warnings")),
(Severity::Info, "notes", ("Note", "Notes")),
]
.map(|(severity, key, words)| {
.map(|(severity, key, (one, other))| {
let (shown, on_shown) = (self.shown.clone(), self.on_shown.clone());
let found = count(severity);
let label = format!("{found} {words}{}", if found == 1 { "" } else { "s" });
let label = format::plural(count(severity) as u64, one, other);
ToggleButton::new(
(self.id.clone(), key),
ToggleItem::new(key).icon(severity.icon()).label(label),