Panics · P09 Overlays: a lightbox or tour past its last item closes

This commit is contained in:
ZacharyZhang-NY committed 2026-10-06 17:14:09 -04:00
1 parent 7af7c409c9
commit 8f00d2eabb
4 files changed
+35 -15

No files matched your search

+2 -1
View File
@@ -23,7 +23,7 @@ Each item reads every site in its folders, fixes what the rules name, updates ca
- [x] P06 Forms — `src/forms`
- [x] P07 Navigation — `src/navigation`
- [x] P08 Menus — `src/menus`
- [ ] P09 Overlays — `src/overlays`
- [x] P09 Overlays — `src/overlays`
- [ ] P10 Feedback — `src/feedback`
- [ ] P11 Loading & Motion — `src/motion`
- [ ] P12 Data Display — `src/data_display`
@@ -73,3 +73,4 @@ One line per item: what changed, what stayed and why, review rounds.
- P06: a root path shows whole; `TextInput::select` logs a range past the text or inside a character; the text element logs shaping and paint faults; a unit gone from its list logs; cron runs in the system zone go through `datetime`. Kept: empty choice lists (the owner disables, as AGENTS.md says), one-value contracts, facts by construction. Review: 2 rounds.
- P07: `Wizard::new` takes `on_step` and `on_finish`; tabs, crumbs, history, steps, wizards and pagination with a place their list no longer holds log and mark none; an empty or all-disabled tab strip ignores arrows; a gone recent command is skipped. Kept: non-empty lists, disabled-free switcher and search items, row index parse. Review: 3 rounds.
- P08: no change. Kept: a bar's menus and a pie's slices (one value each); the panel's level lookup, which `settle` fits to the menu before every draw. Review: 1 round.
- P09: a `Lightbox` or `Tour` past its last item logs and closes, handing focus back. Kept: dialog Enter without `focus_first` and popover face builders on an owner's opener (static builder misuse). Review: 1 round.