T18 round 2 fixes: a folder the terminal cannot enter stops the start, and links read combining clusters whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-09-26 01:50:58 -04:00
1 parent 47f3c7d505
commit 99d9bf45d4
7 files changed
+73 -14

No files matched your search

+11 -1
View File
@@ -1,6 +1,6 @@
use gpui::{Entity, TestAppContext, VisualTestContext};
use super::Terminal;
use super::{Target, Terminal};
use crate::{editor::FindOptions, theme::Theme};
fn replayed<'a>(
@@ -69,3 +69,13 @@ fn clearing_drops_the_matches(cx: &mut TestAppContext) {
assert_eq!(terminal.matches(), (0, None));
});
}
#[gpui::test]
fn a_link_keeps_its_combining_marks(cx: &mut TestAppContext) {
let (terminal, cx) = replayed("a https://e.dev/cafe\u{301}/x".as_bytes(), cx);
terminal.read_with(cx, |terminal, _| {
let (_, columns, target) = terminal.link_at(0, 10).expect("a link under column 10");
assert_eq!(columns, 2..22);
assert_eq!(target, Target::Url("https://e.dev/cafe\u{301}/x".into()));
});
}