Primitives · raise: what opens inside a dialog lies over it

gpui 0.2.2 asserts on a deferred draw inside another, and every dialog,
sheet and popover draws inside one, so opening a date field in the
snooze or schedule dialog panicked, as would any list, menu or picker
opened in an overlay. primitives::raise replaces each deferred draw:
at the top it defers as before; inside something raised it leaves a
placeholder in the tree, and its layer lays it out on its own, then
draws it last. check.sh refuses gpui's deferred anywhere else.

The time dialog's rule is now times::ahead, tested for a moment
behind, now itself, a moment ahead and another zone; a gpui test picks
yesterday in the snooze dialog, sees that it has passed and that
nothing is sent, then picks two days ahead and hears that moment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-09-27 01:51:51 -04:00
1 parent 5b0a8443a7
commit 9abab5f2ba
20 files changed
+405 -49

No files matched your search

+4 -4
View File
@@ -3,13 +3,13 @@ use std::rc::Rc;
use gpui::{
Animation, AnimationExt, AnyElement, App, Bounds, Corner, Div, ElementId, Entity,
InteractiveElement, IntoElement, MouseButton, ParentElement, Pixels, ScrollHandle,
SharedString, Stateful, StatefulInteractiveElement, Styled, Window, anchored, canvas, deferred,
div, prelude::*,
SharedString, Stateful, StatefulInteractiveElement, Styled, Window, anchored, canvas, div,
prelude::*,
};
use crate::{
motion,
primitives::{Icon, IconName},
primitives::{Icon, IconName, raise},
theme::{ActiveTheme, ControlSize, Elevation, IconSize, Radius, TextSize},
typography::Ellipsis,
};
@@ -220,7 +220,7 @@ pub(crate) fn float_height(
}),
)
};
deferred(placed.snap_to_window())
raise(placed.snap_to_window())
.with_priority(1)
.into_any_element()
}