Primitives · raise: what opens inside a dialog lies over it

gpui 0.2.2 asserts on a deferred draw inside another, and every dialog,
sheet and popover draws inside one, so opening a date field in the
snooze or schedule dialog panicked, as would any list, menu or picker
opened in an overlay. primitives::raise replaces each deferred draw:
at the top it defers as before; inside something raised it leaves a
placeholder in the tree, and its layer lays it out on its own, then
draws it last. check.sh refuses gpui's deferred anywhere else.

The time dialog's rule is now times::ahead, tested for a moment
behind, now itself, a moment ahead and another zone; a gpui test picks
yesterday in the snooze dialog, sees that it has passed and that
nothing is sent, then picks two days ahead and hears that moment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-09-27 01:51:51 -04:00
1 parent 5b0a8443a7
commit 9abab5f2ba
20 files changed
+405 -49

No files matched your search

+3 -3
View File
@@ -3,14 +3,14 @@ use std::{f32::consts::TAU, rc::Rc};
use gpui::{
Animation, AnimationExt, AnyElement, App, Bounds, ElementId, Entity, FontWeight,
InteractiveElement, IntoElement, MouseButton, ParentElement, Pixels, Point, RenderOnce,
SharedString, Styled, Window, anchored, canvas, deferred, div, point,
SharedString, Styled, Window, anchored, canvas, div, point,
};
use smallvec::SmallVec;
use crate::{
forms::{Pick, Run},
motion,
primitives::{Icon, IconName, give_back, take_focus},
primitives::{Icon, IconName, give_back, raise, take_focus},
theme::{ActiveTheme, Elevation, IconSize, TextSize},
};
@@ -302,7 +302,7 @@ impl RenderOnce for PieMenu {
}
});
region.child(
deferred(
raise(
anchored()
.position(point(Pixels::ZERO, Pixels::ZERO))
.child(