From a9fd0b58a7979c2be37051763ed96bf230d15876 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 1 Oct 2026 12:55:27 -0400 Subject: [PATCH] =?UTF-8?q?T48g=20Docs=20=C2=B7=20Motion=20passes=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TASKS.md | 2 +- frontend/src/docs/motion.md | 4 ++-- tasks/reviews.md | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/TASKS.md b/TASKS.md index 03b746b..4e78fb1 100644 --- a/TASKS.md +++ b/TASKS.md @@ -170,7 +170,7 @@ Per-component lines live in `tasks/`. Tags there: - [x] T48d Docs · Getting started: an app from `init` to a window under a root `FocusScope`, with a Button - [x] T48e Docs · Theme: modes, tokens through `cx.theme()`, high contrast, color-blind safe charts, an owner's palette - [x] T48f Docs · Focus and keyboard: Tab and Shift-Tab, the root scope, tab stops, the focus ring, overlays that take and give back focus -- [ ] T48g Docs · Motion: durations, reduced motion, springs, motion from a change +- [x] T48g Docs · Motion: durations, reduced motion, springs, motion from a change - [ ] T48h Docs · Icons, fonts and assets: `Assets`, `IconName`, adding icons, the embedded fonts, file icons - [ ] T48i Docs · Overlays: what draws over the page, dialogs, popovers, toasts - [ ] T48j Docs · Internationalization: the `I18n` global, catalogs, right-to-left diff --git a/frontend/src/docs/motion.md b/frontend/src/docs/motion.md index dff019d..6e72960 100644 --- a/frontend/src/docs/motion.md +++ b/frontend/src/docs/motion.md @@ -8,7 +8,7 @@ Ely's motion lives in `ely_gpui_component::motion`: four durations, a few easing | --- | --- | | `FAST`, `BASE`, `SLOW` | 120, 200 and 320 ms. | | `THEME` | 280 ms, the theme's cross-fade. | -| `NUDGE` | 4px, the travel of a small entrance. | +| `NUDGE` | 4px, the unit a small entrance travels by. | | `duration(base, cx)` | `base`, or 1 ms under reduced motion. Pass every duration through it. | | `ease_out_cubic`, `ease_in_out_cubic`, `lerp` | Plain functions of `t` from 0 to 1. | | `spring` | A damped spring. It overshoots past 1 before it settles. | @@ -34,7 +34,7 @@ Under it, `duration` returns 1 ms, so a change lands at once. A motion that repe | `Flash::new(id, key)` | A tint each time `key` changes, fading out. | | `Shake::new(id, key)` | A shake each time `key` changes; still under reduced motion. | | `Spinner`, `ProgressBar`, `ProgressRing` | Progress, held still under reduced motion where they repeat. | -| `Skeleton`, `Shimmer` | Placeholders while content loads. | +| `Skeleton`, `Shimmer` | A placeholder while content loads, and a band that sweeps over what it holds. | | `Flip`, `AnimatePresence`, `Reorder` | Keyed rows that glide to new places, enter, leave, or drag. | `Flash` and `Shake` read the time since `key` changed; they do not restart an animation, so what they hold keeps its focus and state. diff --git a/tasks/reviews.md b/tasks/reviews.md index ded1492..e419b3e 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -336,3 +336,4 @@ | T48d | 1 | PASS | note taken: the lead and the table both count four parts | | T48e | 1 | PASS | notes taken: `mode()` in the read table, `platform` among update's fields | | T48f | 1 | PASS | note taken: a button's own handle is built with tab_stop(true) | +| T48g | 1 | PASS | notes taken: NUDGE is the unit an entrance travels by; Shimmer is a sweeping band |