Panics · P35 Settings: handlers in new; gone sections and themes mark none, drifted font sizes peg

src/settings/tests/appearance.rs

@@ -8,9 +8,13 @@ use crate::settings::{AccentColorPicker, FontSizeControl};
 
 fn accent(_: &mut Window, _: &mut App, owner: Entity<Desk>) -> AnyElement {
     let (red, blue) = (hsla(0.0, 0.6, 0.5, 1.0), hsla(0.6, 0.6, 0.5, 1.0));
-    AccentColorPicker::new("accent", red, [("Red", red), ("Blue", blue)])
-        .on_change(move |color, _, cx| say(&owner, format!("blue {}", color == blue), cx))
-        .into_any_element()
+    AccentColorPicker::new(
+        "accent",
+        red,
+        [("Red", red), ("Blue", blue)],
+        move |color, _, cx| say(&owner, format!("blue {}", color == blue), cx),
+    )
+    .into_any_element()
 }
 
 /// Stops: the presets, Red then Blue, then the custom well.
@@ -23,9 +27,10 @@ fn a_preset_sets_the_accent(cx: &mut TestAppContext) {
 }
 
 fn default_size(_: &mut Window, _: &mut App, owner: Entity<Desk>) -> AnyElement {
-    FontSizeControl::new("size", 14.0, 14.0, (12.0, 24.0))
-        .on_change(move |size, _, cx| say(&owner, format!("size {size}"), cx))
-        .into_any_element()
+    FontSizeControl::new("size", 14.0, 14.0, (12.0, 24.0), move |size, _, cx| {
+        say(&owner, format!("size {size}"), cx)
+    })
+    .into_any_element()
 }
 
 /// At the default size the way back rests, so the second stop wraps to the slider.
@@ -43,7 +48,12 @@ fn many_presets(_: &mut Window, _: &mut App, _: Entity<Desk>) -> AnyElement {
         .collect();
     div()
         .w(px(280.0))
-        .child(AccentColorPicker::new("accent", presets[0].1, presets).on_change(|_, _, _| {}))
+        .child(AccentColorPicker::new(
+            "accent",
+            presets[0].1,
+            presets,
+            |_, _, _| {},
+        ))
         .into_any_element()
 }
 
@@ -61,3 +71,35 @@ fn many_presets_fold_inside_a_narrow_box(cx: &mut TestAppContext) {
         "its swatches fold to a second row: {picker:?}"
     );
 }
+
+/// A size saved past the range, a section and a code palette no longer offered.
+fn drifted(_: &mut Window, _: &mut App, _: Entity<Desk>) -> AnyElement {
+    let sections = [("a", "Appearance", crate::primitives::IconName::Palette)];
+    div()
+        .w(px(480.0))
+        .child(FontSizeControl::new(
+            "size",
+            40.0,
+            9.0,
+            (12.0, 24.0),
+            |_, _, _| {},
+        ))
+        .child(crate::settings::SettingsLayout::new(
+            "layout",
+            sections,
+            "gone",
+            |_, _, _| {},
+        ))
+        .child(crate::settings::SyntaxThemePicker::new(
+            "syntax",
+            crate::theme::syntax_themes(),
+            "Gone",
+            |_, _, _| {},
+        ))
+        .into_any_element()
+}
+
+#[gpui::test]
+fn settings_that_drifted_draw(cx: &mut TestAppContext) {
+    let _ = desk(drifted, cx);
+}