Git · rows draw their focus ring; row actions show while the keyboard is on them

src/git/blame.rs

@@ -198,6 +198,8 @@ impl RenderOnce for BlameView {
                                         .role(Role::Button)
                                         .aria_label(said)
                                         .tab_index(0)
+                                        .border_1()
+                                        .border_color(gpui::transparent_black())
                                         .focus_ring(cx)
                                         .cursor_pointer()
                                         .hover(|gutter| gutter.bg(colors.hover))

src/git/changes.rs

@@ -169,6 +169,8 @@ impl ChangesList {
             .aria_label(file.path.clone())
             .aria_selected(picked)
             .tab_index(0)
+            .border_1()
+            .border_color(gpui::transparent_black())
             .focus_ring(cx)
             .when(picked, |row| row.bg(colors.selection))
             .flex()
@@ -214,6 +216,9 @@ impl ChangesList {
             )
             .child(
                 div()
+                    .id("actions")
+                    .focusable()
+                    .in_focus(|actions| actions.opacity(1.))
                     .flex()
                     .opacity(0.)
                     .group_hover(group, |actions| actions.opacity(1.))

src/git/commits.rs

@@ -78,6 +78,8 @@ impl RenderOnce for CommitItem {
             .aria_label(spoken)
             .aria_selected(self.selected)
             .tab_index(0)
+            .border_1()
+            .border_color(gpui::transparent_black())
             .focus_ring(cx)
             .flex_1()
             .min_w_0()

src/git/history.rs

@@ -76,6 +76,8 @@ impl RenderOnce for FileHistory {
                         .aria_label(commit.subject.clone())
                         .aria_selected(picked)
                         .tab_index(0)
+                        .border_1()
+                        .border_color(gpui::transparent_black())
                         .focus_ring(cx)
                         .flex()
                         .gap_3()

src/git/refs.rs

@@ -227,6 +227,8 @@ pub(super) fn listed(
                 .aria_label(pick.spoken)
                 .aria_selected(pick.selected)
                 .tab_index(0)
+                .border_1()
+                .border_color(gpui::transparent_black())
                 .focus_ring(cx)
                 .cursor_pointer()
                 .when(pick.selected, |row| row.bg(colors.selection))
@@ -280,9 +282,12 @@ pub(super) fn listed(
                     )
                 }),
         )
-        // On hover the actions take the words' place.
+        // Hover or keyboard focus shows the actions.
         .child(
             div()
+                .id("actions")
+                .focusable()
+                .in_focus(|actions| actions.opacity(1.))
                 .absolute()
                 .top_0p5()
                 .right_1()

src/git/viewer.rs

@@ -234,6 +234,8 @@ impl RenderOnce for DiffViewer {
                                 .aria_label(spoken(line))
                                 .aria_selected(picked)
                                 .tab_index(0)
+                                .border_1()
+                                .border_color(gpui::transparent_black())
                                 .focus_ring(cx)
                                 .cursor_pointer()
                                 .on_mouse_down(MouseButton::Left, |_, window, _| {
@@ -365,6 +367,8 @@ impl RenderOnce for DiffViewer {
                                     .text_color(colors.fg_subtle)
                                     .when_some(open, |row, open| {
                                         row.tab_index(0)
+                                            .border_1()
+                                            .border_color(gpui::transparent_black())
                                             .focus_ring(cx)
                                             .cursor_pointer()
                                             .hover(|row| row.text_color(colors.fg))