documents: read presses as the parser decoded them
CI / platforms (windows-latest) (push) Failing after 8s
CI / site (push) Successful in 22s
CI / crate (push) Failing after 11m39s
CI / platforms (ubuntu-24.04) (push) Canceled after 0s

Round 3 of R4.5 found five ways the reverse reading drifted from
markdown-rs: kept indents and marks were eaten as joins, autolink text
was decoded, table code kept its escaped pipes, decoded white space
could not join or drop, and C0/C1 numeric references kept their
controls. Matching now tries an equal character first, a drawn space
against any line end next, and drops white space decoded or not;
autolinks read as written, table cell code reads \| as |, and numeric
references follow markdown-rs. The reviewer's probes are regressions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-10-14 11:34:50 -04:00
1 parent d4c614cb7f
commit c35fdac2e3
7 files changed
+223 -32

No files matched your search

+20 -23
View File
@@ -12,6 +12,8 @@ pub enum Escapes {
Markdown,
/// References, as HTML reads them.
Html,
/// Escaped pipes, as a table cell's code reads them.
Pipes,
}
/// A leaf's written span and how it reads.
@@ -208,7 +210,7 @@ struct Read {
impl Read {
fn ends_line(&self) -> bool {
self.raw && matches!(self.ch, '\n' | '\r')
matches!(self.ch, '\n' | '\r')
}
}
@@ -226,6 +228,9 @@ fn read(written: &str, escapes: Escapes) -> Vec<Read> {
(Escapes::Html, '&') => {
html::reference(rest, false).map(|(value, used)| (value, used, at))
}
(Escapes::Pipes, '\\') => {
(rest[1..].starts_with('|')).then(|| ("|".to_string(), 2, at + 1))
}
_ => None,
};
if let Some((value, used, place)) = decoded {
@@ -260,7 +265,10 @@ fn reference(text: &str) -> Option<(String, usize)> {
let fits =
(1..=most).contains(&digits.len()) && digits.chars().all(|ch| ch.is_digit(radix));
let code = u32::from_str_radix(digits, radix).ok().filter(|_| fits)?;
let ch = char::from_u32(code).filter(|ch| *ch != '\0');
// Controls become U+FFFD, as markdown-rs reads them.
let ch = char::from_u32(code).filter(|ch| {
!matches!(ch, '\0'..='\u{08}' | '\u{0B}' | '\u{0E}'..='\u{1F}' | '\u{7F}'..='\u{9F}')
});
Some(ch.unwrap_or(char::REPLACEMENT_CHARACTER).to_string())
};
let value = match name.strip_prefix('#') {
@@ -279,34 +287,23 @@ fn align(drawn: &str, written: &str, escapes: Escapes, at: usize) -> Option<usiz
}
let source = read(written, escapes);
let mut j = source.len();
let mut shown = drawn.char_indices().rev().peekable();
while let Some((byte, d)) = shown.next() {
for (byte, d) in drawn.char_indices().rev() {
let found = loop {
let s = source[..j].last()?;
// A join: a line's end and the marks after it.
if d.is_whitespace() && (s.ends_line() || s.lead) {
while source[..j].last().is_some_and(|s| s.lead) {
j -= 1;
}
j -= 1;
let crlf = source[j].ch == '\n' && j > 0;
if crlf && source[j - 1].ends_line() && source[j - 1].ch == '\r' {
j -= 1;
}
if d == '\n' && shown.peek().is_some_and(|(_, ch)| *ch == '\r') {
let (cr, _) = shown.next().expect("peeked");
if cr == at {
return Some(source[j].at);
}
}
break source[j].at;
}
if d == s.ch {
j -= 1;
break s.at;
}
// A join: a line's end drawn as white space.
if d.is_whitespace() && s.ends_line() {
j -= 1;
if s.ch == '\n' && j > 0 && source[j - 1].ch == '\r' && source[j - 1].raw == s.raw {
j -= 1;
}
break source[j].at;
}
// White space, line ends and marks the text dropped.
if s.raw && (matches!(s.ch, ' ' | '\t') || s.ends_line() || s.lead) {
if s.lead || matches!(s.ch, ' ' | '\t') || s.ends_line() {
j -= 1;
continue;
}