Misc · Web: the web view hands the keyboard back
WKWebView takes AppKit's first responder on a press and gpui's view never asks for it back, so typed text went to the page for good. The web view now hands it back through wry's focus_parent on every press gpui gets and when its page drops. The gallery proves it with a native key after a press on the page. in_view builds only where it is used, its test covers a box that straddles the view's top, and the embed's frame takes the card's bottom corners.
This commit is contained in:
1 parent
012a6e3105
commit
c7c4c006a7
6 files changed
+52
-10
No files matched your search
+1
-1
@@ -340,7 +340,7 @@
|
||||
|
||||
## T42f Misc · Web
|
||||
|
||||
- [x] WebView — proven: `wry` 0.57 lays a child WKWebView over the window → `misc::WebView`, an address or the owner's HTML, following its box each frame and hidden out of view; it draws above gpui and ignores its clipping. macOS only
|
||||
- [x] WebView — proven: `wry` 0.57 lays a child WKWebView over the window → `misc::WebView`, an address or the owner's HTML, following its box each frame and hidden out of view; it draws above gpui and ignores its clipping, and a press anywhere gpui draws, or the view leaving, hands the keyboard back. macOS only
|
||||
- [x] IframeEmbed / EmbedCard → `misc::IframeEmbed`, a page in a frame of its own under its address, with Open in browser; EmbedCard is `chat::LinkPreviewCard`
|
||||
- [x] HTMLPreview → `misc::WebView`
|
||||
- [x] PrintButton — blocked: gpui 0.2.2 has no print API
|
||||
|
||||
Reference in new issue
Block a user