From ca76311fd3fde7a96aed6ad83cc2b31ee9b6fc1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B7=E7=94=B5=E8=8A=BD=E8=A1=A3?= Date: Thu, 1 Oct 2026 13:22:35 -0400 Subject: [PATCH] =?UTF-8?q?T48j=20Docs=20=C2=B7=20Internationalization=20p?= =?UTF-8?q?asses=20review?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TASKS.md | 2 +- frontend/src/docs/i18n.md | 2 +- tasks/reviews.md | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/TASKS.md b/TASKS.md index 6e232e3..1a9ffaa 100644 --- a/TASKS.md +++ b/TASKS.md @@ -173,7 +173,7 @@ Per-component lines live in `tasks/`. Tags there: - [x] T48g Docs · Motion: durations, reduced motion, springs, motion from a change - [x] T48h Docs · Icons, fonts and assets: `Assets`, `IconName`, adding icons, the embedded fonts, file icons - [x] T48i Docs · Overlays: what draws over the page, dialogs, popovers, toasts -- [ ] T48j Docs · Internationalization: the `I18n` global, catalogs, right-to-left +- [x] T48j Docs · Internationalization: the `I18n` global, catalogs, right-to-left - [ ] T48k Docs · WebAssembly: the web gallery build, its URL, the host protocol, what stays native - [ ] T48l Docs · Testing: the `test-support` feature, frames, clocks and reduced motion in tests - [ ] T48m Docs · E2E: the Docs routes, rail, list, previous and next, and code blocks under Playwright diff --git a/frontend/src/docs/i18n.md b/frontend/src/docs/i18n.md index 22ed5be..4faf6a2 100644 --- a/frontend/src/docs/i18n.md +++ b/frontend/src/docs/i18n.md @@ -27,7 +27,7 @@ Ely's components take their words from the app: a `Button`'s label, a `Dialog`'s ## Right to left -He-IL reads right to left. `direction.row(element)` lays a flex row from the reading side, and `direction.align(element)` aligns text to that side. +The he-IL locale reads right to left. `direction.row(element)` lays a flex row from the reading side, and `direction.align(element)` aligns text to that side. GPUI sets no paragraph direction, so a line runs the way its first strong letter does. `text` leads a right-to-left message with a right-to-left mark, so its words suit labels, not a field's value. `number` leads a right-to-left minus with a left-to-right mark, as CLDR does. GPUI wraps right-to-left lines in the wrong order, so keep such text on one line, an `Ellipsis`. diff --git a/tasks/reviews.md b/tasks/reviews.md index 19c9619..9df7d18 100644 --- a/tasks/reviews.md +++ b/tasks/reviews.md @@ -340,3 +340,4 @@ | T48h | 1 | PASS | note taken: init checks icons/check.svg | | T48i | 1 | FAIL | said tooltips and toasts take focus; gave a centered dialog a close button | | T48i | 2 | PASS | | +| T48j | 1 | PASS | note taken: the he-IL tag keeps its case |