Markdown: display math through RaTeX, Mermaid through mermaid-rs-renderer, pictures from the owner's folder
CI / site (push) Successful in 32s
CI / platforms (windows-latest) (push) Successful in 4m47s
CI / crate (push) Failing after 25m44s
CI / platforms (ubuntu-24.04) (push) Canceled after 0s

Latex typesets with RaTeX to outlined SVG drawn by gpui's SvgRenderer at the
window's scale, loaded as an asset off the main thread. Diagram draws a
mermaid block in Mermaid's theme for the mode. MarkdownRenderer::base names
the folder pictures load from; data addresses decode, web ones stay unloaded.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-10-11 23:38:22 -04:00
1 parent 508cc55af6
commit d5ecc5a69e
11 files changed
+927 -328

No files matched your search

+272
View File
@@ -0,0 +1,272 @@
use std::{
path::{Path, PathBuf},
sync::Arc,
};
use base64::Engine as _;
use gpui::{
AnyElement, App, Asset, Hsla, Image, ImageAssetLoader, ImageFormat, InteractiveElement,
IntoElement, ParentElement, RenderImage, RenderOnce, Resource, SMOOTH_SVG_SCALE_FACTOR,
SharedString, Styled, Window, div, img, px,
};
use crate::{
i18n,
primitives::{Icon, IconName},
theme::{ActiveTheme, IconSize, Radius},
};
/// Where a picture's bytes come from.
#[derive(Clone, Debug, PartialEq)]
pub(crate) enum Origin {
File(PathBuf),
/// Bytes inline in the address, and their type.
Data(ImageFormat, Arc<[u8]>),
Web,
/// A relative path with no folder to read it in.
Loose,
/// An address that names no picture, and why.
Bad(SharedString),
}
/// `%XX` decoded; a broken escape stays as written.
fn decoded(text: &str) -> Vec<u8> {
let bytes = text.as_bytes();
let (mut out, mut at) = (Vec::with_capacity(bytes.len()), 0);
while at < bytes.len() {
let pair = bytes.get(at + 1..at + 3);
let hex =
pair.and_then(|pair| u8::from_str_radix(std::str::from_utf8(pair).ok()?, 16).ok());
match (bytes[at], hex) {
(b'%', Some(byte)) => (out.push(byte), at += 3),
(byte, _) => (out.push(byte), at += 1),
};
}
out
}
/// A path written in a link, `%XX` decoded.
fn path(written: &str) -> Result<PathBuf, SharedString> {
String::from_utf8(decoded(written))
.map(PathBuf::from)
.map_err(|_| "the path is not UTF-8".into())
}
/// Where `url` points, read from the folder `base`.
pub(crate) fn origin(url: &str, base: Option<&Path>) -> Origin {
let url = url.trim();
let lower = url.to_ascii_lowercase();
if lower.starts_with("http://") || lower.starts_with("https://") || url.starts_with("//") {
return Origin::Web;
}
if lower.starts_with("data:") {
return inline(url);
}
if let Some(rest) = url.strip_prefix("file://") {
let rest = rest.strip_prefix("localhost").unwrap_or(rest);
// Windows writes file:///C:/…
let rest = match rest.as_bytes() {
[b'/', _, b':', ..] if cfg!(windows) => &rest[1..],
_ => rest,
};
return path(rest).map_or_else(Origin::Bad, Origin::File);
}
let scheme = url.split_once(':').is_some_and(|(scheme, _)| {
scheme.len() > 1
&& scheme
.chars()
.all(|ch| ch.is_ascii_alphanumeric() || "+-.".contains(ch))
});
if scheme {
return Origin::Bad(format!("{url} is no picture address").into());
}
let written = url.split(['?', '#']).next().unwrap_or_default();
match path(written) {
Ok(path) if path.is_absolute() => Origin::File(path),
Ok(path) => base.map_or(Origin::Loose, |base| Origin::File(base.join(path))),
Err(why) => Origin::Bad(why),
}
}
/// A `data:` address: base64 bytes of an image type.
fn inline(url: &str) -> Origin {
let Some((head, payload)) = url[5..].split_once(',') else {
return Origin::Bad("the data address has no comma".into());
};
let Some(mime) = head.strip_suffix(";base64") else {
return Origin::Bad("only base64 data addresses draw".into());
};
let Some(format) = ImageFormat::from_mime_type(&mime.to_ascii_lowercase()) else {
return Origin::Bad(format!("{mime} is no image type").into());
};
match base64::engine::general_purpose::STANDARD.decode(payload.trim()) {
Ok(bytes) => Origin::Data(format, bytes.into()),
Err(error) => Origin::Bad(format!("{error}").into()),
}
}
/// Inline bytes decoded as gpui decodes files.
enum Unpacker {}
impl Asset for Unpacker {
type Source = (ImageFormat, Arc<[u8]>);
type Output = Result<Arc<RenderImage>, SharedString>;
fn load(
(format, bytes): Self::Source,
cx: &mut App,
) -> impl Future<Output = Self::Output> + Send + 'static {
let renderer = cx.svg_renderer();
async move {
Image::from_bytes(format, bytes.to_vec())
.to_image_data(renderer)
.map_err(|error| format!("{error:#}").into())
}
}
}
/// The picture at `url`, natural size up to the column.
#[derive(IntoElement)]
pub(crate) struct Picture {
pub alt: String,
pub url: String,
/// The folder relative addresses start from.
pub base: Option<Arc<Path>>,
}
impl RenderOnce for Picture {
fn render(self, window: &mut Window, cx: &mut App) -> impl IntoElement {
picture(&self.alt, &self.url, self.base.as_deref(), window, cx)
}
}
fn picture(
alt: &str,
url: &str,
base: Option<&Path>,
window: &mut Window,
cx: &mut App,
) -> AnyElement {
let colors = cx.theme().colors.clone();
let (loaded, svg) = match origin(url, base) {
Origin::File(path) => {
let svg = path
.extension()
.is_some_and(|ext| ext.eq_ignore_ascii_case("svg"));
let resource = Resource::Path(path.into());
let loaded = window
.use_asset::<ImageAssetLoader>(&resource, cx)
.map(|loaded| loaded.map_err(|error| SharedString::from(error.to_string())));
(loaded, svg)
}
Origin::Data(format, bytes) => {
let svg = format == ImageFormat::Svg;
(window.use_asset::<Unpacker>(&(format, bytes), cx), svg)
}
Origin::Web => {
let said = i18n::text(cx, "markdown.picture.web", &[]);
return note(alt, said, colors.fg_subtle, cx);
}
Origin::Loose => {
let said = i18n::text(cx, "markdown.picture.folder", &[]);
return note(alt, said, colors.fg_subtle, cx);
}
Origin::Bad(why) => return note(alt, why, colors.danger, cx),
};
match loaded {
Some(Ok(image)) => {
let natural = image.size(0);
// The picture's own height follows its ratio.
let smooth = if svg { SMOOTH_SVG_SCALE_FACTOR } else { 1.0 };
let width = i32::from(natural.width) as f32 / smooth;
div()
.debug_selector(|| "markdown-picture".into())
.w_full()
.max_w(px(width))
.child(img(image).size_full())
.into_any_element()
}
Some(Err(why)) => {
log::warn!("markdown: a picture did not load: {why}");
note(alt, why, colors.danger, cx)
}
None => note(alt, url.to_string().into(), colors.fg_subtle, cx),
}
}
/// A picture not drawn: its alt text and why.
fn note(alt: &str, said: SharedString, tone: Hsla, cx: &App) -> AnyElement {
let theme = cx.theme();
let colors = &theme.colors;
div()
.flex()
.items_center()
.gap_2()
.p_3()
.rounded(theme.radius(Radius::Md))
.border_1()
.border_color(colors.border)
.text_color(colors.fg_muted)
.child(
Icon::new(IconName::Image)
.size(IconSize::Sm)
.color(colors.fg_subtle),
)
.child(div().flex_1().child(alt.to_string()))
.child(div().text_color(tone).child(said))
.into_any_element()
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn addresses_resolve_against_the_folder() {
let base = Path::new("/notes");
assert_eq!(
origin("assets/a%20b.png?x#y", Some(base)),
Origin::File(base.join("assets/a b.png"))
);
assert_eq!(origin("assets/a.png", None), Origin::Loose);
assert_eq!(origin("https://e.x/a.png", Some(base)), Origin::Web);
assert_eq!(origin("//e.x/a.png", Some(base)), Origin::Web);
assert!(matches!(origin("mailto:a@b", Some(base)), Origin::Bad(_)));
let absolute = std::env::current_dir().expect("a dir").join("a.png");
assert_eq!(
origin(&absolute.display().to_string(), Some(base)),
Origin::File(absolute)
);
}
#[test]
fn file_addresses_decode() {
assert_eq!(
origin("file:///tmp/a%23b.png", None),
Origin::File(PathBuf::from("/tmp/a#b.png"))
);
if cfg!(windows) {
assert_eq!(
origin("file:///C:/notes/a.png", None),
Origin::File(PathBuf::from("C:/notes/a.png"))
);
}
}
#[test]
fn data_addresses_carry_their_bytes() {
assert_eq!(
origin("data:image/png;base64,cG5n", None),
Origin::Data(ImageFormat::Png, Arc::from(&b"png"[..]))
);
assert!(matches!(origin("data:image/png,raw", None), Origin::Bad(_)));
assert!(matches!(
origin("data:text/plain;base64,eA==", None),
Origin::Bad(_)
));
assert!(matches!(
origin("data:image/png;base64,***", None),
Origin::Bad(_)
));
}
}