ZacharyZhang-NY/Ely-GPUI-Components
1
1 Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

Panics · P32 Canvas: panels take their handlers in new; stale nodes, shapes, layers and topics change nothing

Browse Source
This commit is contained in:
ZacharyZhang-NY committed 2026-10-07 05:02:40 -04:00
1 parent 3741d5d5e8
commit ffe4f38103
27 files changed
+471 -297
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

examples/gallery/pages/canvas/boards.rs
+13 -5
View File
@@ -221,18 +221,26 @@ pub fn mind(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
change(&added, cx, |mind| {
mind.made += 1;
let key = SharedString::from(format!("idea-{}", mind.made));
mind.root = mind.root.adding(parent, Topic::new(key.clone(), "New idea"));
mind.selected = Some(key);
if let Some(root) = mind.root.adding(parent, Topic::new(key.clone(), "New idea")) {
mind.root = root;
mind.selected = Some(key);
}
})
})
.on_remove(move |key, _, cx| {
change(&removed, cx, |mind| {
mind.selected = mind.root.parent_of(key);
mind.root = mind.root.removing(key);
if let Some(root) = mind.root.removing(key) {
mind.selected = mind.root.parent_of(key);
mind.root = root;
}
})
})
.on_rename(move |key, text, _, cx| {
change(&renamed, cx, |mind| mind.root = mind.root.renaming(key, text.clone()))
change(&renamed, cx, |mind| {
if let Some(root) = mind.root.renaming(key, text.clone()) {
mind.root = root;
}
})
})
.on_viewport(move |next, _, cx| change(&viewed, cx, |mind| mind.view = next)),
cx,
examples/gallery/pages/canvas/looks.rs
+8 -16
View File
@@ -121,9 +121,8 @@ pub fn styles(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.gap_6()
.child(
div().w(px(260.)).child(
ColorPanel::new("canvas-color", color)
.swatches(SWATCHES.map(|(name, hex)| (name, Hsla::from(rgb(hex)))))
.on_change(move |next, _, cx| change(&colored, cx, |look| look.color = next)),
ColorPanel::new("canvas-color", color, move |next, _, cx| change(&colored, cx, |look| look.color = next))
.swatches(SWATCHES.map(|(name, hex)| (name, Hsla::from(rgb(hex))))),
),
)
.child(
@@ -137,8 +136,7 @@ pub fn styles(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.on_change(move |next, _, cx| change(&graded, cx, |look| look.stops = next.to_vec())),
)
.child(
ShadowEditor::new("canvas-shadows", shadows)
.on_change(move |next, _, cx| change(&shaded, cx, |look| look.shadows = next)),
ShadowEditor::new("canvas-shadows", shadows, move |next, _, cx| change(&shaded, cx, |look| look.shadows = next)),
),
)
.child(
@@ -148,15 +146,13 @@ pub fn styles(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.flex_col()
.gap_6()
.child(
BorderEditor::new("canvas-border", border)
.on_change(move |next, _, cx| change(&bordered, cx, |look| look.border = next)),
BorderEditor::new("canvas-border", border, move |next, _, cx| change(&bordered, cx, |look| look.border = next)),
)
.child(div().p_6().child(card)),
)
.child(
div().w(px(280.)).child(
TypographyPanel::new("canvas-type", style, &search)
.on_change(move |next, _, cx| change(&typed, cx, |look| look.style = next)),
TypographyPanel::new("canvas-type", style, &search, move |next, _, cx| change(&typed, cx, |look| look.style = next)),
),
),
)
@@ -282,8 +278,7 @@ pub fn rules(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.flex_col()
.gap_3()
.child(
ConstraintsEditor::new("canvas-constraints", constraints)
.on_change(move |next, _, cx| change(&pinned, cx, |rules| rules.constraints = next)),
ConstraintsEditor::new("canvas-constraints", constraints, move |next, _, cx| change(&pinned, cx, |rules| rules.constraints = next)),
)
.child(pinned_preview),
)
@@ -294,8 +289,7 @@ pub fn rules(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.flex_col()
.gap_3()
.child(
AutoLayoutControls::new("canvas-auto-layout", layout)
.on_change(move |next, _, cx| change(&laid, cx, |rules| rules.layout = next)),
AutoLayoutControls::new("canvas-auto-layout", layout, move |next, _, cx| change(&laid, cx, |rules| rules.layout = next)),
)
.child(laid_preview),
)
@@ -306,9 +300,7 @@ pub fn rules(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
.flex_col()
.gap_3()
.child(
ExportPanel::new("canvas-export", "Card", exports)
.on_change(move |next, _, cx| change(&set, cx, |rules| rules.exports = next))
.on_export(move |files, _, cx| change(&sent, cx, |rules| rules.exported = files)),
ExportPanel::new("canvas-export", "Card", exports, move |next, _, cx| change(&set, cx, |rules| rules.exports = next), move |files, _, cx| change(&sent, cx, |rules| rules.exported = files)),
)
.when(!exported.is_empty(), |panel| {
panel.child(note(format!("Exported {}", exported.join(", ")).into()))
examples/gallery/pages/canvas/panels.rs
+12 -13
View File
@@ -134,19 +134,18 @@ pub fn arrange(window: &mut Window, cx: &mut App) -> impl IntoElement + use<> {
studio.record(align.words().into());
})
});
let inspector =
InspectorPanel::new("canvas-inspector", chosen).on_change(move |shape, _, cx| {
change(&edited, cx, |studio| {
let at = studio
.shapes
.iter()
.position(|each| each.key == shape.key)
.expect("a listed shape");
let words = format!("Edit {}", shape.name);
studio.shapes[at] = shape;
studio.record(words);
})
});
let inspector = InspectorPanel::new("canvas-inspector", chosen, move |shape, _, cx| {
change(&edited, cx, |studio| {
let at = studio
.shapes
.iter()
.position(|each| each.key == shape.key)
.expect("a listed shape");
let words = format!("Edit {}", shape.name);
studio.shapes[at] = shape;
studio.record(words);
})
});
let assets = AssetPanel::new("canvas-assets")
.group("Shapes", shapes())
.group("Notes", notes())