diff --git a/scripts/review.sh b/scripts/review.sh index a8e20cb..26fcc84 100755 --- a/scripts/review.sh +++ b/scripts/review.sh @@ -21,7 +21,7 @@ prompt="You review item $id of Ely Office, round $round. Work dir is the project Read the line for $id in $list and the PRD.md sections it cites (for tasks/BUGS.md: its entry in docs/BugList.md); the items before it in that list are done. Scope: $scope Find defects only: behavior that breaks the PRD, errors swallowed, silent fallbacks, dead code, files over 500 lines, comments over one line or ten words, boxes inside boxes or useless subtitles in UI, abstractions with one user, missing or weak tests, claims no evidence backs. Build and run the tests yourself. -Copies of the tree you build for probes use their own CARGO_TARGET_DIR, never ./target: crates bake their source path in. Delete those copies and their target dirs before you write the verdict; keep only small logs. +Copies of the tree you build for probes use their own CARGO_TARGET_DIR, never ./target: crates bake their source path in. Delete those copies and their target dirs before you write the verdict; keep only small logs, in .work/ under the project root. Write nothing in the folder above the project. On Windows, build and run nothing under %TEMP%: Application Control blocks programs there. Linux runs in WSL (wsl -d Ubuntu); its clone at ~/Documents/Github/ElyOffice holds this tree's changes. Do not suggest enhancements. Do not reject for taste. Edit no file except the verdict. Round 2 and later: read the previous verdict tasks/reviews/$id-r$((round - 1)).md, confirm each defect is fixed, then look for new defects in changed code. diff --git a/tasks/BUGS.md b/tasks/BUGS.md index 1946dc6..ba5362e 100644 --- a/tasks/BUGS.md +++ b/tasks/BUGS.md @@ -70,7 +70,7 @@ - [x] M-07 崩溃恢复的未命名副本按“第一个显示的未命名标签”配对,内容可能落错标签 — 未命名副本按新建时记下的标签号配对,经 Keeping::take(审查 2 轮) - [x] M-08 页面重载后悬着的渲染回调永不完成,导出既不成功也不报错 — 页面失败后挂起与新到的渲染都以错误结束,载入成功才恢复(审查 2 轮) - [x] M-09 导出的保存面板出错被当作取消 — 面板出错走 panel_failed,取消只记日志(审查 1 轮) -- [ ] M-10 关闭查找框只清当前标签的高亮 +- [x] M-10 关闭查找框只清当前标签的高亮 — 关闭查找框对每个标签的页面清除高亮(审查 1 轮) - [ ] M-11 页面把搜索词写进应用日志 - [ ] M-12 浏览器创建完成前 `WebView` 已释放,浏览器泄漏 - [ ] M-13 编辑器构建失败时页面空白且不上报 diff --git a/tasks/reviews/M-10-r1.md b/tasks/reviews/M-10-r1.md new file mode 100644 index 0000000..7ef22e9 --- /dev/null +++ b/tasks/reviews/M-10-r1.md @@ -0,0 +1 @@ +PASS