diff --git a/tasks/reviews/D-04-r1.md b/tasks/reviews/D-04-r1.md new file mode 100644 index 0000000..be1a039 --- /dev/null +++ b/tasks/reviews/D-04-r1.md @@ -0,0 +1,5 @@ +FAIL + +apps/ely-doc/src/review.rs:372 — The unreadable-note line omits the author and parsing reason required by D-04, and collapses all affected notes into the first raw timestamp. `threads()` stores `(note.at, error)` at line 400; rendering discards `error` and uses only `.first()`. Reproduced in the built native app with a DOCX containing a dated ValidAuthor note, undated MissingDateAuthor and OtherMissingAuthor notes, and one tracked insertion: the normal note and change remain, but the entire error display is `Comments with unreadable times: 2, first 0-00-00`. Neither affected author nor either reason appears. Preserve each failed note's author and reason and render its required InlineMessage line; keep the missing time explicit. Extend the regression to assert those displayed values and retention of changes through the refresh path: both existing review tests pass despite this failure. Builds of ely-lok workers and ely-doc passed; five i18n tests also passed. Native evidence: /tmp/ely-d04-r1-logs/verification.log. + +apps/ely-doc/src/review.rs:374 — The new error display is absent from the system accessibility tree, violating PRD UX-12. In the same native fixture, `tests/scripts/ax-values.swift` exposes `ValidAuthor: Valid note body`, the tracked insertion, ChangeAuthor, and Accept/Reject controls, while the visibly rendered unreadable-time line and its `0-00-00` text are entirely absent. The pinned InlineMessage implementation renders plain div/text children without accessibility semantics, and this call supplies no accessible wrapper. Expose the line through a stable element id, an alert role, and its full localized accessible name, and verify the actual AX text with an unreadable-note fixture. Evidence: /tmp/ely-d04-r1-logs/ax-comments.log and /tmp/ely-d04-r1-logs/ax-changes.log. diff --git a/tasks/reviews/D-04-r2.md b/tasks/reviews/D-04-r2.md new file mode 100644 index 0000000..ed57f67 --- /dev/null +++ b/tasks/reviews/D-04-r2.md @@ -0,0 +1,3 @@ +FAIL + +apps/ely-doc/src/review.rs:360 — The per-note error list has unbounded height outside either pane's scroll area. Opening a DOCX with eight undated comments, one dated ValidAuthor comment and one ChangeAuthor insertion in the default 1100×720 native window pushes both valid lists below the window, breaking D-04 and PRD DOC-11. Reproduced after building ely-lok workers and ely-doc: the window bottom is screen y=964, the valid comment center is y=1106, and the insertion's individual Accept/Reject buttons are at y=1077. The screenshot shows error lines filling the sidebar and continuing beyond its bottom; eight downward scroll events over the sidebar leave the valid comment at y=1106. The log still reports `review lists 9 notes, 1 changes`. Place the errors in a bounded scrolling region or the pane's scrolling content so valid comments and individual revision actions remain reachable; add a rendered regression covering multiple unreadable notes. Both review tests and all five i18n tests pass despite this failure. Round 1's per-note information and AX exposure fixes were independently confirmed with two undated notes. Evidence: `/tmp/ely-d04-r2-logs/verification.log`, `ax-many-comments.log`, `ax-many-changes.log`, and `ax-many-after-scroll.log`. diff --git a/tasks/reviews/D-04-r3.md b/tasks/reviews/D-04-r3.md new file mode 100644 index 0000000..5305b12 --- /dev/null +++ b/tasks/reviews/D-04-r3.md @@ -0,0 +1,3 @@ +FAIL + +tests/scripts/doc-review.sh:2 — The new header comment has 11 words, exceeding the ten-word limit in agents.md and this review's explicit criteria. Running `python3 tests/scripts/comments.py` exits 1 and reports this line; it is the checker’s sole failure. Shorten the comment to ten words or fewer. Evidence: `/tmp/ely-d04-r3-logs/comments.log`. The worker/application build, both review tests, five i18n tests, and the native window regression passed; independent AX inspection confirms the round-2 fix (valid comment center y=550 within window y=244–964, individual Accept/Reject at y=521), and invoking individual Accept removes the tracked insertion. diff --git a/tasks/reviews/D-04-r4.md b/tasks/reviews/D-04-r4.md new file mode 100644 index 0000000..7ef22e9 --- /dev/null +++ b/tasks/reviews/D-04-r4.md @@ -0,0 +1 @@ +PASS