Files
ElyOffice/tasks/reviews/R4.11-r3.md
T
ZacharyZhang-NYandClaude Opus 5.5 f18f3adbec R4.11: close as [~] after round 3
All three findings were in the ignored acceptance driver's backup and
restore, not in product code; each is fixed with a regression.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 22:57:21 -04:00

861 B

FAIL

  1. .work/R4.11/lib.ps1:41 — [P2] Partial backup cleanup makes a retry delete restored user files. Start with all four kept files present and hold the backup's settings.json open for reading without delete sharing. Restore-Data restores every original, then the recursive removal deletes the backup's session.json, recent.json, and look.json before throwing on settings.json. Release the handle and retry: line 39 interprets the deleted snapshots as original absence, deletes those three live files, and removes the remaining backup. Reproduced with the unchanged functions and disposable directories; evidence: .work/R4.11-r3/cleanup-probe.log. Separate completed restoration from backup disposal so a partial cleanup cannot re-enter restoration from an incomplete snapshot, and add a regression for this cleanup-failure-and-retry case.