ZacharyZhang-NYandClaude Opus 5.5
35a7bbb904
The canvas offers Ely's menu by target: slide (layouts, comment), text (bullets, numbering, comment), shape or text box, picture (replace, crop), table (insert, delete, merge), each item gated by the kernel's state for its own command. Impress's table borders read as text and drag through R5.3's path; patch 0047 reports every edge's bounds and makes the left edge drag. A line past its bound never moves against the drag, so a still press sends nothing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2.0 KiB
FAIL
-
[P2]
crates/ely-lok/src/table.rs:57— Impress serializes an empty border list as"entries": "", but this parser still requires an array. Inserting a 1×2, 2×1, or 1×1 table producesan unreadable tableand fails to update its border state; the 2×2 control succeeds. The same problem occurs when deleting down to one row or column. Accept Boost's empty-string representation as an empty list while rejecting malformed values, and add single-row/single-column regressions. Reproduced against the rebuilt worker withSAL_DISABLE_OPENCL=1; payloads are in.work/R5.6-r1-table-edge-probe.log. -
[P2]
crates/ely-lok/src/view/borders.rs:73— R5.6 now feeds Impress tables into this path, which unconditionally exposes the left edge as draggable. Impress'scolumn-leftoperation does not resize an ordinary left-to-right table, although it adds an undo entry and passes the worker's success check. On a fresh 2×2 table, dragging that edge 480 twips right moves the guide but leaves the edge at 3929 twips; the interior and right-edge controls move the requested 480 twips. Implement a working Impress left-edge resize through the kernel bridge, preserving one-step undo, and test its resulting geometry. The new Impress regression covers only an interior column edge. Evidence:.work/R5.6-r1-border-edge-probe.log. -
[P2]
crates/ely-lok/src/view/borders.rs:104— The reused Writer clamp permits an outer row or column to shrink to a fixed 40-twip gap, which does not match Impress's minimum sizes. For a fresh 2×2 table, the last inner row is at 545 and the bottom at 1091: dragging upward to the permitted minimum previews a bottom of 585 and sends an offset of -506, but the kernel lands at 1062. The released border therefore differs from the guide by 477 twips (about 32 pixels at 100% zoom); shrinking the right edge also lands short of its guide. Obtain and apply Impress's actual minimum sizes consistently to preview and commit, and add regressions at the shrink limits. Evidence:.work/R5.6-r1-border-edge-probe.log.