ElyOffice/tasks/reviews/R6.2-r1.md

FAIL

1. ../Ely-GPUI-Components/src/menus/draw.rs:251 (also src/menus/aim.rs:70) — [P2] Leaving a row does not invalidate its delayed action. The panel clears over only when its depth differs; moving outside every panel, onto padding, a separator, or a disabled row leaves the old (depth, ix) intact. Reproduction: hover Insert for 75 ms, move outside the menu, and wait another 150 ms: Insert still opens. Likewise, cross Delete inside the aim triangle and then leave the menu: after 300 ms, Delete replaces Insert despite no longer being hovered. Reentering the row also inherits the old deadline, and reopening the context menu elsewhere retains the pending action. In the isolated GPUI build, six corresponding probes failed; see .work/R6.2-r1/probes.log. Invalidate pending hover state on actual row exit and menu replacement, and verify the current hit target before applying a timer. Add regression tests for these transitions. The existing cargo test --lib --features test-support menus:: suite passed all 43 tests, so it currently misses these failures.

2. ../Ely-GPUI-Components/src/menus/draw.rs:198 — [P2] Icon-button rows bypass hover intent. Their move handler cancels the pending task and calls mark immediately, truncating the open submenu even inside the safe triangle. This arrangement exists in ElyMark's context menu: Copy as is followed by formatting buttons (apps/ely-mark/src/view/menu.rs:125, :135). Reproduction: open a submenu above an enabled icon row, then move diagonally across that row toward a lower submenu item. review_aim_crossing_icon_row_keeps_submenu first verifies that the crossing point satisfies aim::toward, then fails because the submenu disappears immediately. Route button-row targeting through the same aim protection, retaining its column, and cover reaching the submenu versus resting on the crossed button. Evidence: .work/R6.2-r1/probes.log.

3. ../Ely-GPUI-Components/src/menus/aim.rs:17 — [P3] New comments violate this review's explicit ten-word limit: this line and line 58 contain 13 words; lines 1 and 80 contain 12. New comments at src/menus/menu.rs:464 and src/menus/tests/aim.rs:15, :41, :144 also exceed the limit. Counting whitespace-separated words reproduces the failures (.work/R6.2-r1/comments.log). Shorten or remove these added comments while keeping each comment on one line.