ElyOffice/tasks/reviews/C00.3-r3.md

PASS

I ran python3 tests/scripts/agents_md.py. It exited 0 and printed "agents.md: 117 component names are public". The component library is at b54500b.

Round 2 defects:

• Methods in impl blocks counted as module items. Fixed. ITEM is now anchored at column 0 (agents_md.py:9). On a scratch copy, theme::{Theme, Mode, set_mode_now, set_palette} exits 1 with "theme::set_mode_now is not public".
• Glob re-exports. Fixed. glob_names reads the top-level pub items of the submodule. motion::{duration, ...} is now in the map (agents.md:51) and passes. lerp and spring from curve::* also pass, which is correct. NoSuch, curve, self, an empty name and {} each exit 1. An unknown module also exits 1, and so does an unresolvable glob.
• Script tests missing from the commands. Fixed. agents.md:100 now lists *.py.
• Source of the gpui rules. Fixed. agents.md:68 now names src/lib.rs and examples/docs/hello.rs as well. The polling ban is in upstream AGENTS.md:116 ("Never poll layout with request_animation_frame"), so the round 2 claim that it had no upstream source was wrong.

Rechecked:

• agents.md:70-79. Each rule matches an upstream source: AGENTS.md lines 45-47, 51-52, 56, 60, 62, 75, 116, 133, 162, 188 and 218; src/lib.rs:57; hello.rs:16-17 and :42.
• Every mapped module is pub mod in src/lib.rs.
• The gap claims hold. DocumentViewer maps every page (documents/viewer.rs:290). FixedFormatToolbar takes an Entity<TextInput>. tables::Spreadsheet is exported. src has no formula bar and no name box. PERF-05 is at PRD.md:732.
• File sizes are within the limit: agents.md has 108 lines and agents_md.py has 48. The only comment in the script is a nine-word docstring.

No defects found.