Files
ElyOffice/tasks/reviews/C01.2c-r3.md
T

1.1 KiB

PASS

Ran: cargo test -p ely-platform -p ely-ui: all pass, including tests/startup.rs (2), tests/logging.rs and the harness-less startup_panic ("2 cases pass"). cargo clippy -p ely-platform -p ely-ui --all-targets: clean. ELY_SMOKE=1 ELY_NO_DIALOG=1 ely-doc: "ready ElyDoc", exit 0. ely-doc with a read-only HOME: exit 1, stderr gives the real reason ("cannot create …/ElyOffice/ely-doc: Permission denied") and "日志 / Log: none, logging did not start".

Round 2:

  1. fail named a log file it had not checked: fixed. logging::init_in stores the path it actually opened in LOG_PATH, and only after try_init succeeds (logging.rs:53). fail prints logging::path(), or says there is no log (startup.rs:19-22). tests/startup.rs asserts that stderr names the temp-dir log. It also asserts that without a logger the text says "none" and names no ely.log. I confirmed the read-only-home case by hand on the real binary.

New: none found. Each file is under 500 lines. Each comment is one line of ten words or fewer. Every public item has a caller. The 未验证 list in TASKS.md still matches what was not exercised.