Files
ElyOffice/tasks/reviews/C05.1-r3.md
T

1.6 KiB

PASS

Checked: cargo test -p ely-ui -p ely-platform passes (ely-ui 11 unit tests including run::tests and startup_panic, ely-platform 12 update tests and the rest). cargo clippy -p ely-ui -p ely-platform --all-targets is clean. tests/scripts/theme.sh passes on macOS, including the live swap, the empty theme and the return. references.sh, agents_md.py and comments.py pass. All 22 fixtures are byte-identical to reference/omarchy/themes/*/colors.toml at f45461a. I built env.rs and accessibility.rs alone in a scratch crate with the project toolchain (1.96.0), and cargo check passes for x86_64-unknown-linux-gnu and x86_64-pc-windows-msvc, so the cross-compile claim still holds after the wrapper was removed. Every file is under 500 lines.

Round 2:

  1. Fixed. palette.rs:130-133 lifts success, warning, danger and info against bg and their *_subtle. TEXT_PAIRS (palette.rs:32-35) and verify check them. These pairs match the library's tooling/a11y.rs:35-38 exactly. tests.rs:73-80 asserts all four on all 22 themes, and tests.rs:123-130 checks that a red which already reads is kept. The claims in TASKS.md ("正文与状态色 4.5:1") and agents.md ("各自的表面") now match the code.
  2. Fixed. run.rs:36-46 matches unset, 1 and hold explicitly and warns on anything else through env::value. run.rs:93-99 tests this, and agents.md:112 documents hold.
  3. Fixed. accessibility.rs:6-8 logs the full-motion fallback only when neither the variable nor the OS gives an answer.
  4. Fixed. The wrapper is gone, and reduce_motion calls os_reduce_motion directly.

New defects: none found in the changed code.