Files
ElyOffice/tasks/reviews/R6.12-r2.md
T
2026-10-15 19:56:48 -04:00

1.1 KiB

FAIL

  • crates/ely-lok/src/ffi/accessory.rs:65 — Unbundled macOS workers now fail during startup. Setting the main bundle dictionary's LSUIElement leaves their activation policy at 2, which this check rejects. On macOS 27.0.1 arm64, the independently built round 2 worker exited 1 before answering its first IPC request with the worker's activation policy is 2, not accessory; the independently built round 1 worker, using the same engine and fresh profiles, loaded and rendered Writer, Calc and Impress documents and shut down successfully (.work/R6.12-r2/unbundled-r2-worker.log, unbundled-r1.log). This breaks the standalone worker layout used by cargo run and the macOS worker tests. Establish an appropriate policy for unbundled workers while retaining the pre-registration bundle fix, and cover both launch layouts in the regression test.

  • crates/ely-lok/src/ffi/accessory.rs:41 — The new documentation comment contains eleven words, exceeding the explicit ten-word limit. Running python tests/scripts/comments.py exits 1 and identifies this line (.work/R6.12-r2/comments.log). Shorten it to ten words or fewer, or remove it.