Files
ElyOffice/tasks/reviews/R7.5-r1.md
T
2026-10-16 15:01:22 -04:00

2.0 KiB

FAIL

  • ../Ely-GPUI-Components/src/documents/document/visual.rs:179 — The heading styling is overridden by the open input's markdown_highlights: opening # R75 weight changes the final text run from the closed heading's weight 700 to 600; opening ###### R75 color replaces fg_muted with fg. Setting the parent weight/color therefore does not preserve the closed appearance claimed in agents.md:315. Both final-run probes fail in .work/R7.5-r1-probes.log. Preserve heading weight and color in the actual highlighted runs, with regression assertions for these cases.

  • ../Ely-GPUI-Components/src/documents/document/visual.rs:191 — Front matter never enters the monospace branch: parsing gives it Some(nodes), so it falls through to ordinary prose styling. Opening ---\nR75: value\n--- changes JetBrains Mono at TextSize::Sm and fg_muted into the prose font at TextSize::Base and fg, contrary to the preservation claim in agents.md:315. The final-run probe records .SystemUIFont, 0.8125rem instead of 0.75rem, and the wrong color (.work/R7.5-r1-probes.log). Handle TargetBlock::FrontMatter explicitly with its closed typography and test it.

  • ../Ely-GPUI-Components/src/documents/document/tests/open_look.rs:26 — The new tests check geometry but never the backgrounds central to R7.5; the code-panel test at line 52 likewise checks only the container's origin. In isolated mutations, restoring colors.sunken behind open paragraphs and, separately, removing the code/math panel background each leave all 2,118 supplied tests passing. Evidence: .work/R7.5-r1-wash-mutation.log, .work/R7.5-r1-panel-mutation.log; mutation source: .work/R7.5-r1-probe-source.log. Assert the rendered backgrounds so both regressions fail.

  • ../Ely-GPUI-Components/src/documents/document/look.rs:93 — The new comment, “A new layout, a resize or the ends' room moves it.”, contains 11 words and violates the explicit ten-word comment limit. Counting the changed comment's whitespace-separated words reproduces the violation. Shorten it to at most ten words.