2.7 KiB
FAIL
-
[P1] apps/ely-mail/src/syncing.rs:98 — Pause/resume can lose the resumed sync's abort handle. If the old Tokio task has finished but its GPUI completion callback is still queued, pausing takes its handle and resuming starts another task. The old callback then unconditionally sets
syncing.task = Noneat line 74, clearing the new task's handle. A subsequent pause leaves that network task running despite the paused banner. The probe reproducedresumed handle retained=false; paused task cancelled=false(.work/C12.8-r1-probes.log). Associate completion callbacks with their particular sync invocation and ignore obsolete completions; add a regression covering completion queued across pause/resume. The existing pause test waits for the first sync to finish before pausing and cannot detect this failure. -
[P2] apps/ely-mail/src/syncing.rs:135 — Enabling offline retention during a running sync can discard the required download.
set_offlinecallssync, which returns at line 36 whenever that account already has a task. If INBOX has already been processed and the task is waiting on Sent, enabling INBOX offline saves the flag but never revisits INBOX. A real TLS scripted-server probe finished the sync withoffline=true body_cached=false: the old message still had only headers (.work/C12.8-r1-probes.log). Keep a pending resync request or safely restart the account so the changed folder policy is applied before reporting completion; test enabling the flag after that folder has been visited. -
[P2] apps/ely-mail/src/controls.rs:75 — The unbounded folder switch column has no scrolling container, and neither the account body nor Shell supplies one. With 40 folders in a 1100×800 window, the rendered folder list starts at y=630 and ends at y=1782; Remove Account is at y=1798. The later offline switches cannot be reached on screen, preventing per-folder offline configuration (.work/C12.8-r1-probes.log, layout selectors added only to the probe copies). Constrain and scroll the folder list or account content, and verify that later folders remain reachable in a bounded window.
-
[P2] apps/ely-mail/src/view.rs:150 — The download-range row always says that bodies cover the last 90 days and attachments download only when requested, even when a folder has offline retention enabled. After successfully downloading an offline folder, this contradicts both its older cached bodies and
sync::imap's whole-message fetches, which also include attachments. PRD §12.3 requires the displayed download range to reflect the policy. Account for offline folders in this row and test the displayed range after toggling one. Correct the same inaccurate attachment claim in tasks/TASKS.md:144, which currently says offline folders still leave attachments on demand.