Files
ElyOffice/tasks/reviews/C14.2-r3.md
T

1.4 KiB

FAIL

  1. ../Ely-GPUI-Components/src/primitives/held.rs:44 — A departing holder discards its image when another holder remains, but the last holder may still have image: None. For example, two windows start loading the same asset; one stays covered while the other receives and paints the result. Remove the painted element, then close the covered window before it redraws: the last release removes the asset but never calls drop_image, leaving the first window's atlas entry allocated. The exact-source lifecycle probe seeds that pending-holder state and reproduces asset=false, atlas=true after every holder leaves; this is a primitive reproduction, not a native-window visibility test. Retain the loaded image with the shared asset record until the last holder leaves, and cover this release order with an atlas assertion. Evidence: .work/C14.2-r3-pending-source.log and .work/C14.2-r3-pending.log. Round 2's cached-survivor defect is fixed: its original probe now retains both asset and atlas entries. The library's 1748 tests and cargo clippy --all-targets --features test-support -- -D warnings passed.

  2. ../Ely-GPUI-Components/src/primitives/held.rs:56 — The newly changed comment contains 11 whitespace-delimited words: "source as A for element id; the previous one let go." Applying the required ten-word comment rule to this revision fails on that line. Shorten it to ten words or fewer. Evidence: .work/C14.2-r3-checks.log.