Files
ElyOffice/tasks/reviews/C14.4-r1.md
T

2.4 KiB

FAIL

  • [P1] apps/ely-mark/src/view.rs:110 — No initial Reported reaches the shell for files parsed synchronously (up to 128 KiB), or files above LARGEST_READ. MarkdownDocument::new emits its synchronous parse event before this subscription activates, and the view supplies no later initialization event. Opening # Opened\n without editing leaves Desk::observed uncalled: the recent list stays empty, the file has no watcher, extra.base stays empty, and restoration never starts. The first edit also cannot initialize the comparison baseline because the tab is already dirty. A GPUI probe through Desk::open_file reproduced (recent=0, watcher=false, restored=false, base=""); see .work/C14.4-r1-probes.log. Initialize each loaded tab once after the engine subscriptions and tab registration are ready, and test these initial file-session effects.

  • [P2] apps/ely-mark/src/view.rs:99 — large is computed only at construction, although component commit 69b11d7 stops parsing whenever the current text exceeds 2 MiB (Ely-GPUI-Components/src/documents/document/mod.rs:238) and retains the previous parsed blocks. Open # Old, switch to source, select all, paste 2,097,153 bytes of x, then switch to preview: the switch succeeds and the preview/outline still show Old, which is absent from the current file. The clipboard-paste GPUI probe reproduced this; see .work/C14.4-r1-paste.log. Enforce the source-only limit against the current text on changes/replacements and mode switches, invalidate stale parsed content at the cutoff, and cover crossing the threshold after opening.

  • [P2] apps/ely-mark/src/view/tests.rs:52 — a_refresh_is_saved_text_and_keeps_no_undo verifies neither the replacement text nor undo reset. Both its old and new strings have four bytes, and the initial view is already unmodified, so replacing the entire MarkView::refresh body with a no-op still passes this test (verified in the isolated copy; .work/C14.4-r1-refresh-mutant.log). Assert the exact document and shell text after refresh, begin with an actual undoable edit, and exercise undo to prove the disk text cannot revert to the preceding content.

  • [P3] apps/ely-mark/src/view.rs:1 — New comments violate the ten-word limit: this module comment has 12 words, line 15 has 11, line 61 has 12, and apps/ely-mark/src/places.rs:111 has 11. Running python tests/scripts/comments.py fails on exactly these four locations. Shorten each comment to at most ten words.