ElyOffice/tasks/reviews/L1.4-r1.md

FAIL

• tests/scripts/linux-glibc.sh:26 — A failed readelf command is treated as evidence that the ELF is static. With readelf forced to return 1, the existing outputs still exit 0 and report all 187 ELF files compliant (.work/L1.4-r1-readelf-failure.log). A missing tool or failed inspection therefore bypasses every glibc check. Check tool availability explicitly and propagate inspection errors; skip version analysis only after a successful inspection establishes that the binary is static.

• tests/scripts/linux-glibc.sh:19 — Required outputs only need to exist; non-ELF files are skipped at line 23, and line 32 requires just one ELF across all inputs. A compiled probe with eight text files in place of the applications/workers, empty LibreOffice and CEF directories, and one unrelated ELF under Git exits 0 (.work/L1.4-r1-non-elf.log). Validate each required application/worker as an ELF and require the actual engine binaries before scanning their versions.

• tests/scripts/linux-glibc.sh:31 — The find process substitution loses enumeration failures, allowing a partial scan to pass. With valid ELF inputs and an unreadable LibreOffice subdirectory containing another ELF, find reports permission denied, but the test exits 0 and declares the 11 accessible ELF files compliant (.work/L1.4-r1-find-failure.log). Check and propagate the enumeration status before reporting success.

• packaging/linux/container.sh:2 — Scoped comments violate the mandatory one-line, ten-word limit: this line has 12 words, line 12 has 11, packaging/linux/Dockerfile:1 has 12, and tests/scripts/linux-glibc.sh:2 has 11. scripts/build-git.sh:40 and :41 also form consecutive comment lines. The repository comment checker rejects the shell comments (.work/L1.4-r1-comments.log). Shorten the long comments and remove or separate the consecutive explanation and directive.