Files
ElyOffice/tasks/reviews/L1.8-r3.md
T

1.3 KiB

FAIL

tests/scripts/ci-share.sh:33 — The exact-target assertion still strips trailing newlines: $(target ...) removes them after the helper preserves them. In a disposable copy, changing link creation to append a newline to each target leaves the entire suite green, although both links point elsewhere and CI reaches the local packaging stub. The two round 2 mutations now correctly fail, but this target assertion remains incomplete. Preserve a sentinel through the comparison and check the complete stored target. Evidence: .work/L1.8-r3-probes.log.

tests/scripts/ci-share.sh:44 — All rejection cases exercise only engines, leaving rejection of a local or misdirected reference untested. Restricting the guard to engines leaves the suite green; a separate macOS probe then reaches packaging with a local reference directory. Exercise rejected layouts for both entries and assert that each stops before packaging. Evidence: .work/L1.8-r3-probes.log.

tests/scripts/ci-share.sh:29 — The new inline comment has eleven words: “name, setup; the check lets it through to the release step”. This violates the ten-word comment limit; the existing comment checker misses inline shell comments and passes. Shorten the comment to ten words or fewer. Evidence: .work/L1.8-r3-tests.log.