Files
ElyOffice/tasks/reviews/M-05-r1.md
T
ZacharyZhang-NYandClaude Opus 5.5 c5f614d095 ElyMark: the page hands every link click to the app (M-05)
Preview clicks and Cmd/Ctrl clicks in the editor go through one
click handler; it stops the browser and sends the link mark's own
address, since Milkdown blanks unsafe hrefs in the DOM. Reviews run
at effort xhigh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 11:24:05 -04:00

999 B

FAIL

  • apps/ely-mark/src/view.rs:270: The fix handles only Event::Leave, but visual-mode links never produce it. Open [web](https://example.com/) or [mail](mailto:test@example.com) in visual mode and click the link: Chromium treats the anchor as editable text, so no navigation reaches Requests::on_before_browse and neither the browser nor mail client opens. Disallowed links likewise produce no refusal. A WSL probe built the current bundled page and used real Playwright clicks: HTTPS, mailto and FTP each produced zero Page.frameRequestedNavigation events in visual mode; all three produced anchorClick events in preview. Ctrl-click on the visual HTTPS link also produced no navigation. Handle explicit link activation in the visual editor and forward it through the host's allowed/refused link policy. Add regression coverage that clicks rendered links in both modes and verifies opening/refusal; the current Cargo suites contain no M-05 test and pass on WSL despite this failure.